feat(android): add loop prop, onLoad event, fix podspec iOS min version#6
Open
davaidev wants to merge 1 commit intoFeeld:mainfrom
Open
feat(android): add loop prop, onLoad event, fix podspec iOS min version#6davaidev wants to merge 1 commit intoFeeld:mainfrom
davaidev wants to merge 1 commit intoFeeld:mainfrom
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Android (
TransparentVideoViewManager.java)loopprop support (defaulttrue) — saves loop setting per-view, applies whenAlphaMovieViewis created or recreatedonLoadevent viaRCTEventEmitter— fires when video starts playingsetSrciOS (
react-native-transparent-video.podspec)11.0to13.4folly_compiler_flagsvariableMotivation
Compatibility with React Native 0.83 / Expo SDK 55. The
loopprop andonLoadevent are needed for common video playback control from the JS side.Made with Cursor