Support adding "disambiguation suffixes" to filenames on conflicts, instead of overwriting or failing #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fichub_cli would download a file but there's a filename conflict, it currently either errors (by default) or overwrites the existing file (with the
--forceoption). This PR adds a new--disambiguation-suffixoption, which lets the user choose a string to append to the file name to result in a unique filename. Ideally it would be mutually exclusive with--force, but that isn't possible yet1.Footnotes
Instead, we prefer
--forcewhen it is set, falling back to--disambiguation-suffixif it is set, otherwise falling back to erroring. ↩