Adjust LLM run parameters for connection validation#90
Open
Marquis03 wants to merge 11 commits intoFinStep-AI:devfrom
Open
Adjust LLM run parameters for connection validation#90Marquis03 wants to merge 11 commits intoFinStep-AI:devfrom
Marquis03 wants to merge 11 commits intoFinStep-AI:devfrom
Conversation
Add gemini and Ollama provider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the logic for validating the LLM connection in the
validate_llm_connectionfunction. The main changes include adjusting the parameters for the LLM test call and expanding the success criteria to support more result formats.Improvements to LLM connection validation:
contentorreasoning_contentattribute is present and non-empty in the result, making the validation compatible with Reasoning LLM response formats.max_tokensparameter from 1 to 5 and thetemperaturefrom 0.1 to 1.0 in theGLOBAL_LLM.runcall: The original parameter settings (max_tokens=1, temperature=0.1) could cause some models to output only a newline character (\n), which would be stripped out during content validation, leading to false negative results where the LLM connection was incorrectly judged as unresponsive. The adjusted parameters allow for more flexible and meaningful LLM responses during connection testing, avoiding such misjudgments.