Skip to content

This should fix bug #8817 : Fatal lock manager error: invalid lock id #8818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hvlad merged 2 commits into from
Dec 2, 2025
Merged

This should fix bug #8817 : Fatal lock manager error: invalid lock id #8818

hvlad merged 2 commits into from
Dec 2, 2025

Conversation

@hvlad
Copy link
Member

@hvlad hvlad commented Nov 30, 2025

No description provided.

@hvlad hvlad self-assigned this Nov 30, 2025
@hvlad hvlad linked an issue Nov 30, 2025 that may be closed by this pull request
Fatal lock manager error: invalid lock id #8817
Closed
@dyemanov dyemanov self-requested a review December 1, 2025 09:42
dyemanov
dyemanov approved these changes Dec 2, 2025
View reviewed changes
@hvlad hvlad merged commit c642236 into v4.0-release Dec 2, 2025
12 of 16 checks passed
hvlad added a commit that referenced this pull request Dec 3, 2025
@hvlad
Merge pull request #8818 from FirebirdSQL/work/gh-8817
5c5d48e 
This should fix bug #8817 : Fatal lock manager error: invalid lock id
@hvlad hvlad deleted the work/gh-8817 branch December 3, 2025 12:20
hvlad added a commit that referenced this pull request Dec 3, 2025
@hvlad
Merge pull request #8818 from FirebirdSQL/work/gh-8817
a2e406c 
This should fix bug #8817 : Fatal lock manager error: invalid lock id
@dyemanov
Copy link
Member

dyemanov commented Dec 10, 2025

Unfortunately, this commit may cause a hang inside MET_scan_relation. If the new server version adds some virtual table and we open a database from a prior version (that does not contain this table), the new virtual table exists in the att_relations array and MET_scan_relation is called for it, but since it's missing inside RDB$RELATIONS, the REL_scanned flag is never set and we have an infinite loop.

@hvlad
Copy link
Member Author

hvlad commented Dec 10, 2025

Looks like REL_scanned flag should be set for system relation even if it was not found in RDB$RELATIONS ?
And raise isc_relnotdef for non-system relation ?

@dyemanov
Copy link
Member

dyemanov commented Dec 11, 2025

Looks like REL_scanned flag should be set for system relation even if it was not found in RDB$RELATIONS ? And raise isc_relnotdef for non-system relation ?

Sounds like a plan.

@hvlad hvlad mentioned this pull request Dec 15, 2025
Merged
@hvlad
Copy link
Member Author

hvlad commented Dec 15, 2025

Patch is at #8826

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dyemanov dyemanov dyemanov approved these changes

Assignees

@hvlad hvlad

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fatal lock manager error: invalid lock id

2 participants

@hvlad @dyemanov