Add an INetworkConnectionBroadcaster interface#1007
Open
adeutscher wants to merge 3 commits intoFirstGearGames:mainfrom
Open
Add an INetworkConnectionBroadcaster interface#1007adeutscher wants to merge 3 commits intoFirstGearGames:mainfrom
adeutscher wants to merge 3 commits intoFirstGearGames:mainfrom
Conversation
… connection's broadcasting can be more easily mocked.
Author
|
These changes are focused on my short-term goals of unit-testing a section of logic that accepts a NetworkConnection solely to send replies to the client. My hope is that adding this in will be a foot in the door to future abstraction for testing in the vein of #654 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an INetworkConnectionBroadcaster interface, which NetworkConnection implements.