Open
Conversation
… encodes incorrectly if done prior.
Author
|
Also, how does github know I deleted a blank line, and then re-added it?!? Spooky... |
added 2 commits
January 29, 2014 12:40
Member
|
Could you add a test to CMResourceConfigSpec to validate this and make sure the other tests pass with this change? Also, could you explain what the purpose of the project file changes were or leave them out of the pull request? Thanks, yo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the line url encoding the resource string. As URLByAppendingPathComponent will do url encoding, but when sent a pre-encoded string will encode incorrectly.
I havent investigated it much, but it appears its just seeing any percents and encodes them (ie %25) which will destroy any prior encoding.
And encode again for good measure.
Encode.