Allow collapsing json output and fix bug with quotes within a value#20
Open
ahsquared wants to merge 3 commits intoFlatFilers:masterfrom
Open
Allow collapsing json output and fix bug with quotes within a value#20ahsquared wants to merge 3 commits intoFlatFilers:masterfrom
ahsquared wants to merge 3 commits intoFlatFilers:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Martin,
Awesome tool! Love it! Had a bug though when I had quotes within a value, e.g. in the following csv data:
foo bar "baz" more foothe json output would be:
[
{
"foo": "bar "baz" // missing quote here
},
{
"foo": "more foo"
}
]
I removed the trim('"') on the value and tested with lots of inputs and it seems to work. You may have had a good reason for this - would like to know - but for my use cases this works.
I also needed collapsed output, so added an option for that, that just uses JSON.stringify(json).
Cheers,
Andre