Add example of notifications #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example how to implement notification system using multiple delivery system. In out example we use Email and Hipchat. There are two main things to learn: * SendFeedback interactor — the entry point * FeedbackNotification model — class to generate content of different type of notifications
notifications/README.md
Outdated
| private | ||
|
|
||
| def email | ||
| context.feedback.employee.email |
There was a problem hiding this comment.
I think here is the violation of law of demeter. Probably, we can delegate email to feedback?
Contributor
Author
There was a problem hiding this comment.
@ArturMinnullin something like this?
delegate :email, to: context.feedback.employee
| gem "hipchat" | ||
| gem "interactor" | ||
| gem "render_anywhere" | ||
| gem "sidekiq" |
Contributor
There was a problem hiding this comment.
I think it would be good to metion here that If sidekiq has not been added and configured before implementing this feature then it is required to set sidekiq as active job queue adapter in config/application.rb
# config/application.rb
# ...
class Application < Rails::Application
# ...
config.active_job.queue_adapter = :sidekiq
# ...
end
# ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example how to implement notification system using multiple delivery system.
In out example we use Email and Hipchat.
There are two main things to learn: