Skip to content

Updated geode version and added ability to change songs in main menu …#117

Open
coah80 wants to merge 3 commits intoFleeym:mainfrom
coah80:main
Open

Updated geode version and added ability to change songs in main menu …#117
coah80 wants to merge 3 commits intoFleeym:mainfrom
coah80:main

Conversation

@coah80
Copy link

@coah80 coah80 commented Dec 22, 2025

…levels

Added a QOL change to be able to change the songs on the main levels. Allowing for easy NONGs on demons or other levels that have mashups or remixes

heres my changes in video form:
https://www.dropbox.com/scl/fi/lnn0cf9pb80sp75pizblw/CleanShot-2025-12-22-at-14.43.30.mp4?rlkey=8zbdb4f8jkhj9kv1sa5fspxd4&st=06p4awra&dl=0

…levels

Added a QOL change to be able to change the songs on the main levels.
@Fleeym
Copy link
Owner

Fleeym commented Jan 9, 2026

Hi, sorry for being slow with responding, I haven't been as active on the project as I wanted to.

I'll leave a code review in a bit, there's a few things that would need fixing here.

Thanks for the contribution though, this looks really cool!

Copy link
Owner

@Fleeym Fleeym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I got everything that should be fixed. I can make the changes if you want.

@coah80
Copy link
Author

coah80 commented Jan 9, 2026

hey, made the changes you asked for:

  • moved JBLevelSelectLayer to its own file level_select_layer.cpp
  • fixed artist fetching to use LevelTools::artistForAudio() and nameForArtist() instead of parsing the string
  • switched to using node ids (info-menu, info-button) instead of that jbCollectMenuItems thing
  • removed the unnecessary sprite fallback checks
  • added nong-pin id to the sprite and changed button id to nong-button to match CustomSongWidget
  • deleted the unused jbFindTopRightMenuItem function

for the layout thing, im using relative positioning rn which should work on all resolutions. should be easy to switch to a layout once your node ids pr adds it!

also for some reason dash was being pulled as robtop but i just added a manual fix for that one

also also sorry for some things being jank lol, this was my first time messing around with geode

@coah80
Copy link
Author

coah80 commented Jan 9, 2026

also for some reason dash was being pulled as robtop but i just added a manual fix for that one

well i TRIED adding a manual fix for that one but i didnt build and test the manual fix, ill just remove it and let it be robtops baby i guess

@coah80
Copy link
Author

coah80 commented Jan 9, 2026

a1b8c7e

there removed

@coah80 coah80 requested a review from Fleeym January 9, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants