Fixed bug where mods cannot use API to change Fashion Sense bodies#58
Open
GoddessVirtue wants to merge 2 commits into
Open
Fixed bug where mods cannot use API to change Fashion Sense bodies#58GoddessVirtue wants to merge 2 commits into
GoddessVirtue wants to merge 2 commits into
Conversation
…i.cs so other mods can change bodies using API
…e future renaming for clearer and more consistent API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is my suggested fix for issue #57. GetAppearanceModDataKey() can now return the ModDataKeys.CUSTOM_BODY_ID key for the IApi.Type.Player type, which should fix the bug where mods couldn't use the API to change Fashion Sense bodies.
Also, I added an IApi.Type.Body type as an alias to the Player type, because it's more consistent and easier for other devs using the API to understand. If you'd prefer to keep just the Player type, Floogen, I completely understand. I'm not great with Git but hopefully separating the two commits makes that easier for you to do.