improved FileProvider usage #2932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@sosnovsky ping |
Collaborator
|
Hi @DenBond7, will check it today! |
Collaborator
|
I tried to open attachment by clicking 
And then choosing Can it be caused by stricter file permissions in current PR? |
Collaborator
Author
Nope. I have the same behavior on the active production build(Google Play). It looks like Chrome can't handle such a Uri. I can open an attachment like yours via Gmail. |
Collaborator
Author
|
This PR includes internal changes. It can affect Android 9 or less. Android 10 and higher should not be affected by these changes. |
sosnovsky
approved these changes
Feb 3, 2025
Collaborator
sosnovsky
left a comment
sosnovsky
left a comment
There was a problem hiding this comment.
Got it, otherwise looks good 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improved FileProvider usage
close #2930
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):