Skip to content

Fixed empty recipients issue#2957

Merged
sosnovsky merged 5 commits intomasterfrom
issue_2955_fix_recipients
Feb 20, 2025
Merged

Fixed empty recipients issue#2957
sosnovsky merged 5 commits intomasterfrom
issue_2955_fix_recipients

Conversation

@DenBond7
Copy link
Collaborator

@DenBond7 DenBond7 commented Feb 19, 2025

This PR Fixed the empty recipients issue(small internal changes)

close #2955


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities

@DenBond7
Copy link
Collaborator Author

Hello @martgil,

Please try these changes. Please install a fresh version or toggle Load only PGP messages to reload the internal cache before testing.
image

@martgil
Copy link
Collaborator

martgil commented Feb 20, 2025

Hi Den, Thanks - I'll get this tested shortly.

@martgil
Copy link
Collaborator

martgil commented Feb 20, 2025

Hello @DenBond7 I've tested this PR and my emails are now loading very well with complete subject lines.

@DenBond7 DenBond7 marked this pull request as ready for review February 20, 2025 08:29
@DenBond7 DenBond7 requested a review from sosnovsky as a code owner February 20, 2025 08:29
@DenBond7 DenBond7 requested a review from ioanmo226 February 20, 2025 10:03
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@sosnovsky sosnovsky merged commit ac00bd4 into master Feb 20, 2025
7 checks passed
@sosnovsky sosnovsky deleted the issue_2955_fix_recipients branch February 20, 2025 19:40
@DenBond7
Copy link
Collaborator Author

Looks good to me too. Thought I left comment. Missed Submit review button

Thank you @ioanmo226. I will apply your comments in the upcoming PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix empty recipients

3 participants