Skip to content

Fixed a case when Notifications keep coming even after settings option to load "Encrypted only" messages#2997

Merged
ioanmo226 merged 1 commit intomasterfrom
issue_2996_fix_notifications_for_only_encrypted
Apr 7, 2025
Merged

Fixed a case when Notifications keep coming even after settings option to load "Encrypted only" messages#2997
ioanmo226 merged 1 commit intomasterfrom
issue_2996_fix_notifications_for_only_encrypted

Conversation

@DenBond7
Copy link
Collaborator

@DenBond7 DenBond7 commented Apr 7, 2025 •
edited by ioanmo226
Loading

This PR Fixed a case when Notifications keep coming even after settings option to load "Encrypted only" messages

close #2996

Tests (delete all except exactly one):

  • Difficult to test (explain why): this scenario can be tested when the app is in the background and threads syncing runs once per 15 minutes. It is hard(maybe not possible) to create a UI test using Espresso. Tested manually.

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities

@DenBond7 DenBond7 marked this pull request as ready for review April 7, 2025 15:12
@DenBond7 DenBond7 requested a review from ioanmo226 as a code owner April 7, 2025 15:12
@ioanmo226 ioanmo226 merged commit a402126 into master Apr 7, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Notifications keep coming even after settings option to load "Encrypted only" messages

1 participant

@DenBond7