Skip to content

Improved loading and parsing PGPMime Encrypted messages#3021

Merged
ioanmo226 merged 4 commits intomasterfrom
issue_3017_fix_parsing_MIME_message
Apr 25, 2025
Merged

Improved loading and parsing PGPMime Encrypted messages#3021
ioanmo226 merged 4 commits intomasterfrom
issue_3017_fix_parsing_MIME_message

Conversation

@DenBond7
Copy link
Collaborator

@DenBond7 DenBond7 commented Apr 24, 2025

This PR improved loading and parsing PGPMime Encrypted messages + Refactored code

close #3017


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities

@DenBond7 DenBond7 marked this pull request as ready for review April 24, 2025 09:12
@DenBond7 DenBond7 requested a review from ioanmo226 as a code owner April 24, 2025 09:12
@DenBond7
Copy link
Collaborator Author

I think test case for attachment with name msg.asc together with the noname file is not added?

The main changes here are

image

FlowCrypt/src/test/java/com/flowcrypt/email/security/pgp/ProcessMimeMessageTest.kt covers parsing cases like attachment with name msg.asc together with the noname file(PGPMime Encrypted)

But I think you are right. It would be nice to have a UI test for PGPMime Encrypted for Gmail API(conversation view). I will add it.

@DenBond7 DenBond7 marked this pull request as draft April 25, 2025 05:19
@DenBond7 DenBond7 marked this pull request as ready for review April 25, 2025 11:40
@DenBond7 DenBond7 requested a review from ioanmo226 April 25, 2025 11:40
@ioanmo226 ioanmo226 merged commit 6f65245 into master Apr 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unrecognizable encrypted message in FlowCrypt version 1.6.3

1 participant