Skip to content

fix: condition node incorrectly executes nodes on unfulfilled branches with multiple edges #6539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joo9906 wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

fix: condition node incorrectly executes nodes on unfulfilled branches with multiple edges #6539

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5082a7a
Condition Node error fix
joo9906 Jun 22, 2026
9e3b707
Delete .codegraph directory
joo9906 Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/server/src/utils/buildAgentflow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,9 +830,9 @@ async function determineNodesToIgnore(

// Find nodes to ignore based on unfulfilled conditions
for (const index of unfulfilledIndexes) {
const ignoreEdge = edges.find((edge) => edge.source === nodeId && edge.sourceHandle === `${nodeId}-output-${index}`)
const ignoreEdges = edges.filter((edge) => edge.source === nodeId && edge.sourceHandle === `${nodeId}-output-${index}`)

if (ignoreEdge) {
for (const ignoreEdge of ignoreEdges) {
ignoreNodeIds.push(ignoreEdge.target)
}
}
Comment on lines 832 to 838

@gemini-code-assist gemini-code-assist Bot Jun 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Improvement Opportunity

Currently, edges.filter is called inside a loop over unfulfilledIndexes. This results in $O(N \times M)$ complexity, where $N$ is the number of edges and $M$ is the number of unfulfilled indexes.

We can optimize this to $O(N + M)$ by pre-computing the unfulfilled source handles in a Set and filtering the edges array in a single pass.

        const unfulfilledSourceHandles = new Set(unfulfilledIndexes.map((index) => nodeId + "-output-" + index))
        const ignoreEdges = edges.filter((edge) => edge.source === nodeId && unfulfilledSourceHandles.has(edge.sourceHandle))

        for (const ignoreEdge of ignoreEdges) {
            ignoreNodeIds.push(ignoreEdge.target)
        }

Expand Down