Fix duplicate iteration execution tree ids #6545
+38
−70
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -369,19 +369,25 @@ const AgentExecutedDataCard = ({ status, execution, agentflowId, sessionId }) => | |
| }) | ||
|
|
||
| // Identify iteration nodes and their children | ||
| const iterationGroups = new Map() // parent uniqueNodeId -> Map of iterationIndex -> nodes | ||
| const lastSeenIndices = new Map() | ||
|
|
||
| // Group iteration child nodes by their parent and iteration index | ||
| nodes.forEach((node, index) => { | ||
| lastSeenIndices.set(node.nodeId, index) | ||
| if (node.data?.parentNodeId && node.data?.iterationIndex !== undefined) { | ||
| const parentId = node.data.parentNodeId | ||
| const iterationIndex = node.data.iterationIndex | ||
| const parentIndex = lastSeenIndices.get(parentId) | ||
| const parentUniqueNodeId = parentIndex !== undefined ? `${parentId}_${parentIndex}` : null | ||
|
|
||
| if (!parentUniqueNodeId) return | ||
|
Comment on lines
+372
to
+384
Contributor
There was a problem hiding this comment. Instead of performing a backward linear scan ($O(N)$) for every iteration child node to find its parent node's unique ID, we can maintain a map of the most recently seen index for each const iterationGroups = new Map() // parent uniqueNodeId -> Map of iterationIndex -> nodes
const lastSeenIndices = new Map()
// Group iteration child nodes by their parent and iteration index
nodes.forEach((node, index) => {
lastSeenIndices.set(node.nodeId, index)
if (node.data?.parentNodeId && node.data?.iterationIndex !== undefined) {
const parentId = node.data.parentNodeId
const iterationIndex = node.data.iterationIndex
const parentIndex = lastSeenIndices.get(parentId)
const parentUniqueNodeId = parentIndex !== undefined ? parentId + '_' + parentIndex : null
if (!parentUniqueNodeId) return
Author
There was a problem hiding this comment. Updated in 9728aa1 to keep a last-seen parent index map during traversal, which removes the per-child backward scan while preserving the unique node id format. |
||
|
|
||
| if (!iterationGroups.has(parentUniqueNodeId)) { | ||
| iterationGroups.set(parentUniqueNodeId, new Map()) | ||
| } | ||
|
|
||
| const iterationMap = iterationGroups.get(parentUniqueNodeId) | ||
| if (!iterationMap.has(iterationIndex)) { | ||
| iterationMap.set(iterationIndex, []) | ||
| } | ||
|
|
@@ -391,16 +397,10 @@ const AgentExecutedDataCard = ({ status, execution, agentflowId, sessionId }) => | |
| }) | ||
|
|
||
| // Create virtual iteration container nodes | ||
| iterationGroups.forEach((iterationMap, parentUniqueNodeId) => { | ||
| iterationMap.forEach((nodeIds, iterationIndex) => { | ||
| // Find the parent iteration node instance | ||
| const parentNode = nodeMap.get(parentUniqueNodeId) | ||
|
|
||
| if (!parentNode) return | ||
|
|
||
|
|
@@ -410,7 +410,7 @@ const AgentExecutedDataCard = ({ status, execution, agentflowId, sessionId }) => | |
| const iterationContext = firstChild?.data?.iterationContext || { index: iterationIndex } | ||
|
|
||
| // Create a virtual node for this iteration | ||
| const iterationNodeId = `${parentUniqueNodeId}_iteration_${iterationIndex}` | ||
| const iterationLabel = `Iteration #${iterationIndex}` | ||
|
|
||
| // Determine status based on child nodes | ||
|
|
@@ -432,7 +432,7 @@ const AgentExecutedDataCard = ({ status, execution, agentflowId, sessionId }) => | |
| iterationIndex, | ||
| iterationContext, | ||
| isVirtualNode: true, | ||
| parentIterationId: parentNode.nodeId | ||
| }, | ||
| previousNodeIds: [], // Will be handled in the main tree building | ||
| status: iterationStatus, | ||
|
|
@@ -497,31 +497,14 @@ const AgentExecutedDataCard = ({ status, execution, agentflowId, sessionId }) => | |
| }) | ||
|
|
||
| // Second pass: Build the iteration sub-trees | ||
| iterationGroups.forEach((iterationMap, parentUniqueNodeId) => { | ||
| const latestParent = nodeMap.get(parentUniqueNodeId) | ||
|
|
||
| if (!latestParent) return | ||
|
|
||
| // Add all virtual iteration nodes to the parent | ||
| iterationMap.forEach((nodeIds, iterationIndex) => { | ||
| const iterationNodeId = `${parentUniqueNodeId}_iteration_${iterationIndex}` | ||
| const virtualNode = nodeMap.get(iterationNodeId) | ||
| if (virtualNode) { | ||
| latestParent.children.push(virtualNode) | ||
|
|
@@ -547,6 +530,7 @@ const AgentExecutedDataCard = ({ status, execution, agentflowId, sessionId }) => | |
| potentialParent.nodeId === prevNodeId && | ||
| potentialParent.data?.iterationIndex === node.data?.iterationIndex && | ||
| potentialParent.data?.parentNodeId === node.data?.parentNodeId && | ||
| potentialParent.virtualParentId === node.virtualParentId && | ||
| !parentFound | ||
| ) { | ||
| potentialParent.children.push(node) | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of performing a backward linear scan ($O(N)$) for every iteration child node to find its parent node's unique ID, we can maintain a map of the most recently seen index for each$O(1)$ time complexity, preventing potential UI performance degradation when rendering large execution trees.
nodeIdas we iterate. This optimizes the lookup toThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in 9728aa1 to keep a last-seen parent index map during traversal, which removes the per-child backward scan while preserving the unique node id format.