-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Allow sending file uploads without typed message #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Allow sending file uploads without typed message #337
Conversation
Summary of ChangesHello @iokinpardo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant quality-of-life improvement by enabling users to send file uploads directly without requiring an accompanying text message. This streamlines the user experience, particularly for interactions where only files need to be transmitted, by automatically providing a default message when no text is entered. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a great feature that allows users to upload files without typing a message. The implementation in Bot.tsx is mostly solid and clear. I've added a couple of suggestions to improve code efficiency and maintainability. The documentation update in README.md is also clear and helpful.
| // Handle form submission | ||
| const handleSubmit = async (value: string | object, action?: IAction | undefined | null, humanInput?: any) => { | ||
| if (typeof value === 'string' && value.trim() === '') { | ||
| const fileUploadFallbackMessage = 'file uploaded'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The constant fileUploadFallbackMessage is defined inside handleSubmit, which means it's redeclared on every function call. It's better to define it once at a higher scope, for example, at the module level before the Bot component, or right inside the Bot component but outside handleSubmit. This improves performance slightly and follows best practices for constants.
| if (typeof submissionValue === 'string') { | ||
| const trimmedValue = submissionValue.trim(); | ||
| const hasUploads = previews().length > 0; | ||
| const containsFile = previews().filter((item) => !item.mime.startsWith('image') && item.type !== 'audio').length > 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using .filter(...).length > 0 iterates over the entire previews array even after a match is found. For checking existence, .some() is more efficient as it stops as soon as it finds a matching element.
| const containsFile = previews().filter((item) => !item.mime.startsWith('image') && item.type !== 'audio').length > 0; | |
| const containsFile = previews().some((item) => !item.mime.startsWith('image') && item.type !== 'audio'); |
File-only uploads
file uploadedmessage for you.