Conversation
|
@NarHakobyan Oops, I missed your PR and created one for this as well. |
lib/flutter_statusbar_manager.dart
Outdated
| static const String DARK_CONTENT = "dark-content"; | ||
|
|
||
| static String getStyle(StatusBarStyle style) { | ||
| static String getStyle(StatusBarStyle? style) { |
There was a problem hiding this comment.
I think we should not accept null values here
lib/flutter_statusbar_manager.dart
Outdated
| static const String SLIDE = "slide"; | ||
|
|
||
| static String getAnimation(StatusBarAnimation animation) { | ||
| static String getAnimation(StatusBarAnimation? animation) { |
lib/flutter_statusbar_manager.dart
Outdated
| static const String LIGHT = "dark"; | ||
|
|
||
| static String getStyle(NavigationBarStyle style) { | ||
| static String getStyle(NavigationBarStyle? style) { |
|
Hi @amitkot, yeah, it's not necessary to have nullable arguments. I have fixed it. |
|
@amitkot are you still here? :D |
|
@NarHakobyan thanks very much for your PR, I am using it for now unless something else is moving here... Do you have a solution for Edit: I found a solution using |
Fix MissingPluginException for flutter web
|
@NarHakobyan hi, missed your ping (a month ago). |
Hi guys, I migrated package to null safety, to be honest I think this library is no more maintainable so you can use null safety version directly from git.