fix(Oauth): use prompt=login instead of prompt=consent for OIDC tests#402
Closed
ydfdas1f546g1df wants to merge 2 commits into
Closed
fix(Oauth): use prompt=login instead of prompt=consent for OIDC tests#402ydfdas1f546g1df wants to merge 2 commits into
ydfdas1f546g1df wants to merge 2 commits into
Conversation
Owner
|
Thanks for the issue/PR. Unfortunately I would be open to add an option to chose between |
1 task
Owner
|
Superseded by 66ff9e6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #401
Description
Fix OAuth authentication to comply with OIDC standards by replacing
prompt=consentwithprompt=login.According to the OpenID Connect Core 1.0 specification, the
promptparameter accepts specific values:none,login,consent, andid_token. However, for OIDC flows,prompt=loginis the correct choice when requiring re-authentication, asprompt=consentis deprecated and not recommended by OIDC best practices. Theloginprompt parameter ensures the user is authenticated at the OpenID Provider, even if they have an active session.This change aligns the implementation with:
Related Issue: [Reference issue if applicable]
Type of Change
Technical Details
How Has This Been Tested?
go test ./internal/webserver/authentication/oauth/...Checklist
Changes Made
Oauth_test.gotest assertions to expectprompt=logininstead ofprompt=consentprompt=loginfor OIDC compliance