feat: add no_sound icon for videos without an audio track #881

aricodeine · 2026-01-25T07:52:33Z

Type of change(s)

Bug fix
Feature / enhancement
Infrastructure / tooling (CI, build, deps, tests)
Documentation

What changed and why

Added no_sound icon to use for videos without an audio track

Tests performed

Tested on API 36.0 emulator

Preview

Closes the following issue(s)

Closes Gray Out Audio Icon (Mute Button) When Video Contains No Sound #876

Checklist

I read the contribution guidelines.
I manually tested my changes on device/emulator (if applicable).
I updated the "Unreleased" section in CHANGELOG.md (if applicable).
I have self-reviewed my pull request (no typos, formatting errors, etc.).
All checks are passing.

…lery_issue_876

naveensingh · 2026-01-25T08:09:36Z

app/src/main/kotlin/org/fossify/gallery/activities/VideoPlayerActivity.kt

+                // Get the format of the first track in the group to check its type.
+                val format = group.getTrackFormat(0)
+                // Check if the MIME type is an audio type (e.g., "audio/mp4a-latm").
+                format.sampleMimeType?.startsWith("audio/") == true
+            }
+        } ?: false //


Suggested change

// Get the format of the first track in the group to check its type.

val format = group.getTrackFormat(0)

// Check if the MIME type is an audio type (e.g., "audio/mp4a-latm").

format.sampleMimeType?.startsWith("audio/") == true

}

} ?: false //

val format = group.getTrackFormat(0)

format.sampleMimeType?.startsWith("audio/") == true

}

} ?: false

Please avoid obvious comments. Are you using some AI coding agent?

Sorry about that. Yes I am using Gemini on Android Studio. Will do the changes..

For your information, even the latest Gemini model has a high hallucination rate. As of now, AI code contributions are usually not accepted in Fossify (mentioned in the guidelines).

Will keep that in mind, however, I don't copy paste the code without going through it. Will refrain from using the model here from now on :)

naveensingh · 2026-01-25T08:11:56Z

app/src/main/kotlin/org/fossify/gallery/activities/VideoPlayerActivity.kt

+        } ?: false //
+        if (!mHasAudio) {
+            binding.bottomVideoTimeHolder.videoToggleMute.setImageResource(R.drawable.no_sound)
+            binding.bottomVideoTimeHolder.videoToggleMute.isClickable = false


It should show a toast instead, as I proposed here. That's more user-friendly in this case.

I like This video has no audio.

It should show a toast instead, as I proposed here. That's more user-friendly in this case.

You are suggesting having the toast in addition to having the no_audio icon right? -> According to your comment here

Yes. The new icon + toast This video has no audio on click. We can still slightly reduce the alpha (MEDIUM_ALPHA) to get the disabled effect.

naveensingh · 2026-01-25T08:18:36Z

CHANGELOG.md

 ## [Unreleased]
 ### Added
 - Long press gesture to play videos at 2x speed in separate video player ([#830])
+- Added a dedicated icon for videos without an audio track ([#876])


It should go under the changed section:

Suggested change

- Added a dedicated icon for videos without an audio track ([#876])

### Changed

- Mute button is now disabled for videos without an audio track ([#876])

naveensingh · 2026-01-25T09:45:33Z

app/src/main/res/drawable/ic_vector_no_sound.xml

+<vector xmlns:android="http://schemas.android.com/apk/res/android"
+    android:width="24dp"
+    android:height="24dp"
+    android:viewportWidth="960"
+    android:viewportHeight="960"
+    android:tint="?attr/colorControlNormal"
+    android:autoMirrored="true">
+  <path
+      android:fillColor="@android:color/white"
+      android:pathData="M616,640L560,584L664,480L560,376L616,320L720,424L824,320L880,376L776,480L880,584L824,640L720,536L616,640ZM120,600L120,360L280,360L480,160L480,800L280,600L120,600ZM400,354L314,440L200,440L200,520L314,520L400,606L400,354ZM300,480L300,480L300,480L300,480L300,480L300,480Z"/>
+</vector>


File should be named ic_vector_no_sound.xml. See guidelines.

naveensingh · 2026-01-25T10:04:17Z

app/src/main/kotlin/org/fossify/gallery/activities/VideoPlayerActivity.kt

+    private fun checkAudioTrack() {
+        mHasAudio = mExoPlayer?.let { player ->
+            if (player.currentTracks.groups.isEmpty()) {
+                return@let false
+            }
+
+            player.currentTracks.groups.any { group ->
+                // Get the format of the first track in the group to check its type.
+                val format = group.getTrackFormat(0)
+                // Check if the MIME type is an audio type (e.g., "audio/mp4a-latm").
+                format.sampleMimeType?.startsWith("audio/") == true
+            }
+        } ?: false //
+        if (!mHasAudio) {
+            binding.bottomVideoTimeHolder.videoToggleMute.setImageResource(R.drawable.no_sound)
+            binding.bottomVideoTimeHolder.videoToggleMute.isClickable = false
+        }
+    }
+
    private fun videoPrepared() {
+        checkAudioTrack()


It'll be simpler and more reliable to use the existing player listener:

// add in initListeners() override fun onTracksChanged(tracks: Tracks) { updatePlayerMuteState(tracks.containsType(C.TRACK_TYPE_AUDIO)) }

The click listener and updatePlayerMuteState() should be reworked to accept hasAudio and process the click as required (mute/unmute or show toast).

naveensingh · 2026-01-25T10:04:44Z

app/src/main/kotlin/org/fossify/gallery/activities/VideoPlayerActivity.kt

+        if (!mHasAudio) {
+            binding.bottomVideoTimeHolder.videoToggleMute.setImageResource(R.drawable.no_sound)
+            binding.bottomVideoTimeHolder.videoToggleMute.isClickable = false
+        }
+


This shouldn't be needed here with the listener based approach.

naveensingh · 2026-01-25T10:13:58Z

app/src/main/kotlin/org/fossify/gallery/fragments/VideoFragment.kt

+    private fun checkAudioTrack() {
+        mHasAudio = mExoPlayer?.let { player ->
+            if (player.currentTracks.groups.isEmpty()) {
+                return@let false
+            }
+
+            player.currentTracks.groups.any { group ->
+                // Get the format of the first track in the group to check its type.
+                val format = group.getTrackFormat(0)
+                // Check if the MIME type is an audio type (e.g., "audio/mp4a-latm").
+                format.sampleMimeType?.startsWith("audio/") == true
+            }
+        } ?: false //
+        if (!mHasAudio) {
+            binding.bottomVideoTimeHolder.videoToggleMute.setImageResource(R.drawable.no_sound)
+            binding.bottomVideoTimeHolder.videoToggleMute.isClickable = false
+        }
+    }
+
    private fun videoPrepared() {
+        checkAudioTrack()


Same suggestions as the VideoPlayerActivity.

…oPlayerActivity.kt

…issue_876

aricodeine · 2026-01-25T15:22:02Z

@naveensingh done with the changes, I didn't know if the new string property should be in strings.xml, can move it if needed.

naveensingh · 2026-01-25T15:27:48Z

app/src/main/res/values/strings.xml

+
+    <!-- Player-->
+    <string name="video_no_sound">This video has no sound</string>


Please move this section above the FAQ related strings.

I think "audio" fits better than "sound".

Suggested change



<string name="video_no_sound">This video has no sound</string>



<string name="video_no_sound">This video has no audio</string>

naveensingh · 2026-01-25T15:30:39Z

app/src/main/kotlin/org/fossify/gallery/activities/VideoPlayerActivity.kt

+        if (!mWasVideoStarted) {
+            if (!mHasAudio) {
+                toast(R.string.video_no_sound)
+            }
+        }
+


By toast on click, I meant we should show a toast when there is no audio and the mute button is clicked. More info in #881 (comment).

By toast on click, I meant we should show a toast when there is no audio and the mute button is clicked. More info in #881 (comment).

done, it will now show the toast only when the mute button is clicked, provided video was started previously in the same player session

aricodeine added 2 commits January 25, 2026 13:12

added no_sound icon for videos without an audio track

73c9445

updated CHANGELOG.md

5ba604e

aricodeine requested a review from naveensingh as a code owner January 25, 2026 07:52

aricodeine and others added 2 commits January 25, 2026 13:22

Merge branch 'main' into gallery_issue_876

4b7dc41

Merge branch 'main' of https://github.com/aricodeine/Gallery into gal…

fc9af0a

…lery_issue_876

naveensingh changed the title ~~added no_sound icon for videos without an audio track~~ feat: add no_sound icon for videos without an audio track Jan 25, 2026

naveensingh requested changes Jan 25, 2026

View reviewed changes

aricodeine added 2 commits January 25, 2026 20:47

updated the alpha value of icon, CHANGELOG.md, VideoFragment.kt, Vide…

54a6147

…oPlayerActivity.kt

Merge remote-tracking branch 'origin/gallery_issue_876' into gallery_…

f13b80d

…issue_876

aricodeine requested a review from naveensingh January 25, 2026 15:20

naveensingh requested changes Jan 25, 2026

View reviewed changes

aricodeine added 2 commits January 25, 2026 21:05

updated strings.xml

1f62636

updated VideoFragment.kt and VideoPlayerActivity.kt

e7c80f9

aricodeine requested a review from naveensingh January 25, 2026 15:56

	- Added a dedicated icon for videos without an audio track ([#876])
	### Changed
	- Mute button is now disabled for videos without an audio track ([#876])


		<!-- Player-->
		<string name="video_no_sound">This video has no sound</string>

Uh oh!

feat: add no_sound icon for videos without an audio track #881

Are you sure you want to change the base?

feat: add no_sound icon for videos without an audio track #881

Conversation

aricodeine commented Jan 25, 2026 • edited by fossifybot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change(s)

What changed and why

Tests performed

Preview

Closes the following issue(s)

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aricodeine Jan 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

naveensingh Jan 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aricodeine commented Jan 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aricodeine Jan 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

aricodeine commented Jan 25, 2026 •

edited by fossifybot bot

Loading

aricodeine Jan 25, 2026 •

edited

Loading

naveensingh Jan 25, 2026 •

edited

Loading

aricodeine commented Jan 25, 2026 •

edited

Loading

aricodeine Jan 25, 2026 •

edited

Loading