Skip to content

Rework "text only MMS" implementation #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ljrk0 wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Rework "text only MMS" implementation #674

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5e04fc3
fix: Add missing column to projection
ljrk0 Jan 22, 2026
63bab12
fix: SMS "locked" wrong value in export
ljrk0 Jan 22, 2026
0f0f97a
Implement top-level logic for text-only MMS exports
ljrk0 Jan 22, 2026
e464423
Implement `includeTextOnlyMMSasSMS`
ljrk0 Jan 22, 2026
4351c89
Rework/fix includeTextOnlyAttachment
ljrk0 Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
208 changes: 171 additions & 37 deletions app/src/main/kotlin/org/fossify/messages/helpers/MessagesReader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,14 @@ package org.fossify.messages.helpers
import android.annotation.SuppressLint
import android.content.Context
import android.net.Uri
import android.provider.Telephony
import android.provider.Telephony.Mms
import android.provider.Telephony.Sms
import android.util.Base64
import com.google.android.mms.ContentType
import com.google.android.mms.pdu_alt.PduHeaders
import org.fossify.commons.extensions.getIntValue
import org.fossify.commons.extensions.getIntValueOrNull
import org.fossify.commons.extensions.getLongValue
import org.fossify.commons.extensions.getStringValue
import org.fossify.commons.extensions.getStringValueOrNull
Expand All @@ -31,16 +35,20 @@ class MessagesReader(private val context: Context) {
var smsMessages = listOf<SmsBackup>()
var mmsMessages = listOf<MmsBackup>()

// Special-case "Text only" MMS:
// - If only-backup-sms: backup text-only MMS as SMS
// - If only-backup-mms: exclude text-only MMS
// - If both: backup text-only MMS as MMS
if (getSms) {
smsMessages = getSmsMessages(conversationIds)
smsMessages = getSmsMessages(conversationIds, includeTextOnlyMMSasSMS = !getMms)
}
if (getMms) {
mmsMessages = getMmsMessages(conversationIds)
mmsMessages = getMmsMessages(conversationIds, getSms)
}
callback(smsMessages + mmsMessages)
}

private fun getSmsMessages(threadIds: List<Long>): List<SmsBackup> {
private fun getSmsMessages(threadIds: List<Long>, includeTextOnlyMMSasSMS: Boolean = false): List<SmsBackup> {
val projection = arrayOf(
Sms.SUBSCRIPTION_ID,
Sms.ADDRESS,
Expand Down Expand Up @@ -70,7 +78,7 @@ class MessagesReader(private val context: Context) {
val body = cursor.getStringValueOrNull(Sms.BODY)
val date = cursor.getLongValue(Sms.DATE)
val dateSent = cursor.getLongValue(Sms.DATE_SENT)
val locked = cursor.getIntValue(Sms.DATE_SENT)
val locked = cursor.getIntValue(Sms.LOCKED)
val protocol = cursor.getStringValueOrNull(Sms.PROTOCOL)
val read = cursor.getIntValue(Sms.READ)
val status = cursor.getIntValue(Sms.STATUS)
Expand All @@ -93,6 +101,117 @@ class MessagesReader(private val context: Context) {
)
}
}

/* stores text only MMS as SMS */
if (!includeTextOnlyMMSasSMS) { return smsList }
val mmsProjection = arrayOf(
Mms._ID,

Mms.SUBSCRIPTION_ID,
/* ADDRESS : getMmsAddresses() */
/* BODY : getParts() */
Mms.DATE,
Mms.DATE_SENT,
Mms.LOCKED,
/* PROTOCOL : null */
Mms.READ,
Mms.STATUS,
Mms.MESSAGE_BOX,
/* SERVICE_CENTER : null */
)

val mmsSelection = "${Mms.THREAD_ID} = ?"

threadIds.map { it.toString() }.forEach { threadId ->
val selectionArgs = arrayOf(threadId)
context.queryCursor(Mms.CONTENT_URI, mmsProjection, mmsSelection, selectionArgs) { cursor ->
val mmsId = cursor.getLongValue(Mms._ID)

val subscriptionId = cursor.getLongValue(Mms.SUBSCRIPTION_ID)
val addresses = getMmsAddresses(mmsId)
val address = addresses.first { it.type == PduHeaders.FROM }.address

/* body done at the end */

val date = cursor.getLongValue(Mms.DATE) * 1000
val dateSent = cursor.getLongValue(Mms.DATE_SENT) * 1000
val locked = cursor.getIntValue(Mms.LOCKED)
val protocol = null
val read = cursor.getIntValue(Mms.READ)
val mmsStatus = cursor.getIntValueOrNull(Mms.STATUS)
val status = when (mmsStatus) {
null, PduHeaders.STATUS_UNRECOGNIZED, PduHeaders.STATUS_INDETERMINATE -> {
Telephony.TextBasedSmsColumns.STATUS_NONE
}
PduHeaders.STATUS_EXPIRED, PduHeaders.STATUS_UNREACHABLE, PduHeaders.STATUS_REJECTED -> {
Telephony.TextBasedSmsColumns.STATUS_FAILED
}
PduHeaders.STATUS_DEFERRED, PduHeaders.STATUS_FORWARDED -> {
Telephony.TextBasedSmsColumns.STATUS_PENDING
}
PduHeaders.STATUS_RETRIEVED -> {
Telephony.TextBasedSmsColumns.STATUS_COMPLETE
}
else -> {
/* unreachable? */
Telephony.TextBasedSmsColumns.STATUS_NONE
}
}

val messageBox = cursor.getIntValue(Mms.MESSAGE_BOX)
val type = when (messageBox) {
Telephony.BaseMmsColumns.MESSAGE_BOX_INBOX -> {
Telephony.TextBasedSmsColumns.MESSAGE_TYPE_INBOX
}
Telephony.BaseMmsColumns.MESSAGE_BOX_OUTBOX -> {
Telephony.TextBasedSmsColumns.MESSAGE_TYPE_OUTBOX
}
Telephony.BaseMmsColumns.MESSAGE_BOX_DRAFTS -> {
Telephony.TextBasedSmsColumns.MESSAGE_TYPE_DRAFT
}
Telephony.BaseMmsColumns.MESSAGE_BOX_FAILED -> {
Telephony.TextBasedSmsColumns.MESSAGE_TYPE_FAILED
}
Telephony.BaseMmsColumns.MESSAGE_BOX_SENT -> {
Telephony.TextBasedSmsColumns.MESSAGE_TYPE_SENT
}
else -> {
/* unreachable */
Telephony.TextBasedSmsColumns.MESSAGE_TYPE_ALL
}
}

val serviceCenter = null

/* We do not rely on TEXT_ONLY MMS flag, see also getMmsMessages() */
val parts = getParts(mmsId)
val smil = parts.filter { it.contentType == ContentType.APP_SMIL }
val plain = parts.filter { it.contentType == ContentType.TEXT_PLAIN }
val others = parts.filter { it.contentType != ContentType.APP_SMIL && it.contentType != ContentType.TEXT_PLAIN }

if (smil.size <= 1 && plain.size == 1 && others.size == 0) {
val body = plain.first().text

smsList.add(
SmsBackup(
subscriptionId = subscriptionId,
address = address,
body = body,
date = date,
dateSent = dateSent,
locked = locked,
protocol = protocol,
read = read,
status = status,
type = type,
serviceCenter = serviceCenter
)
)
}
}
}


return smsList
}

Expand All @@ -115,23 +234,16 @@ class MessagesReader(private val context: Context) {
Mms.SEEN,
Mms.TEXT_ONLY,
Mms.STATUS,
Mms.SUBJECT,
Mms.SUBJECT_CHARSET,
Mms.SUBSCRIPTION_ID,
Mms.TRANSACTION_ID
)
val selection = if (includeTextOnlyAttachment) {
"${Mms.THREAD_ID} = ? AND ${Mms.TEXT_ONLY} = ?"
} else {
"${Mms.THREAD_ID} = ?"
}
val selection = "${Mms.THREAD_ID} = ?"
val mmsList = mutableListOf<MmsBackup>()

threadIds.map { it.toString() }.forEach { threadId ->
val selectionArgs = if (includeTextOnlyAttachment) {
arrayOf(threadId, "1")
} else {
arrayOf(threadId)
}
val selectionArgs = arrayOf(threadId)
context.queryCursor(Mms.CONTENT_URI, projection, selection, selectionArgs) { cursor ->
val mmsId = cursor.getLongValue(Mms._ID)
val creator = cursor.getStringValueOrNull(Mms.CREATOR)
Expand All @@ -145,7 +257,7 @@ class MessagesReader(private val context: Context) {
val read = cursor.getIntValue(Mms.READ)
val readReport = cursor.getIntValue(Mms.READ_REPORT)
val seen = cursor.getIntValue(Mms.SEEN)
val textOnly = cursor.getIntValue(Mms.TEXT_ONLY)
var textOnly = cursor.getIntValue(Mms.TEXT_ONLY)
val status = cursor.getStringValueOrNull(Mms.STATUS)
val subject = cursor.getStringValueOrNull(Mms.SUBJECT)
val subjectCharSet = cursor.getStringValueOrNull(Mms.SUBJECT_CHARSET)
Expand All @@ -154,29 +266,51 @@ class MessagesReader(private val context: Context) {

val parts = getParts(mmsId)
val addresses = getMmsAddresses(mmsId)
mmsList.add(
MmsBackup(
creator = creator,
contentType = contentType,
deliveryReport = deliveryReport,
date = date,
dateSent = dateSent,
locked = locked,
messageType = messageType,
messageBox = messageBox,
read = read,
readReport = readReport,
seen = seen,
textOnly = textOnly,
status = status,
subject = subject,
subjectCharSet = subjectCharSet,
subscriptionId = subscriptionId,
transactionId = transactionId,
addresses = addresses,
parts = parts

// If textOnly was set to 1, we trust that judgement, as this was explicitly set.
// However, since 0 is the default value [1], it's common for "text only" messages to have
// this set to 0, despite. This is also the reason why we do not use this flag for filtering
// within the query.
//
// [1]: https://cs.android.com/android/platform/superproject/main/+/main:packages/providers/TelephonyProvider/src/com/android/providers/telephony/MmsSmsDatabaseHelper.java;l=2512;drc=61197364367c9e404c7da6900658f1b16c42d0da
if (textOnly == 0) {
// Effectively the same logic as in AOSP [2] when categorizing incoming messages.
//
// [2]: https://cs.android.com/android/platform/superproject/main/+/main:frameworks/base/telephony/common/com/google/android/mms/pdu/PduPersister.java;l=1346;drc=6a5fcafd33cb3068235f1d76a8a6939886e15a71
textOnly = 1
if (parts.size > 2) { textOnly = 0 }
for (part in parts) {
if (ContentType.APP_SMIL != part.contentType && ContentType.TEXT_PLAIN != part.contentType) {
textOnly = 0
}
}
}

if (includeTextOnlyAttachment || textOnly == 0) {
mmsList.add(
MmsBackup(
creator = creator,
contentType = contentType,
deliveryReport = deliveryReport,
date = date,
dateSent = dateSent,
locked = locked,
messageType = messageType,
messageBox = messageBox,
read = read,
readReport = readReport,
seen = seen,
textOnly = textOnly,
status = status,
subject = subject,
subjectCharSet = subjectCharSet,
subscriptionId = subscriptionId,
transactionId = transactionId,
addresses = addresses,
parts = parts
)
)
)
}
}
}
return mmsList
Expand Down
Loading