Fix nvoglv64.dll crash in VoxelShadowGrid by using PBO for texture upload#145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting an EXCEPTION_ACCESS_VIOLATION crash in nvoglv64.dll because the NVIDIA OpenGL driver could defer DMA and later read from client memory that had already been freed. This commit replaces the direct ByteBuffer upload with a Pixel Buffer Object (PBO) in VoxelShadowGrid.uploadBuffer, staging the upload through GPU-managed buffer storage and fixing the crash
and well this is the log
hs_err_pid42988.log