Lift definition of alt outcomes up one step#1892
Open
CarlosFdez wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
This is a merge to Harry's PR, so the one that decides is Harry I imagine once he's happy to return to it. |
Contributor
|
Yah, I'm going to check on this again sometime soon. I've gotten a bit more thoughtful about the whole thing due to a few things. But lifting it up like this so Effects and Damage can be under the same level should definately be a good thing regardless |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Damage is now part of the alt outcome data, with the intent for a single alt outcome field to contain all variations. In essence this allows the altOutcomes data structure to drive more of the logic for rendering its subelements, which you can see in the update to getOutcomeTabs() and the outcomes tab template.
getOutcomeTabs() should probably be no longer a static method but now an internal data prep function for the context, but one thing at a time.
AltOutcome is in its own file to avoid cyclical imports. Actions point to sheets in their metadata, which makes things rather tricky for import order. Any action sheet importing from the damage field file directly will cause an error on startup.