Skip to content

Lift definition of alt outcomes up one step#1892

Open
CarlosFdez wants to merge 2 commits into
feature/granular-action-outcomesfrom
umbrella-outcomes
Open

Lift definition of alt outcomes up one step#1892
CarlosFdez wants to merge 2 commits into
feature/granular-action-outcomesfrom
umbrella-outcomes

Conversation

@CarlosFdez
Copy link
Copy Markdown
Contributor

@CarlosFdez CarlosFdez commented May 16, 2026

Damage is now part of the alt outcome data, with the intent for a single alt outcome field to contain all variations. In essence this allows the altOutcomes data structure to drive more of the logic for rendering its subelements, which you can see in the update to getOutcomeTabs() and the outcomes tab template.

getOutcomeTabs() should probably be no longer a static method but now an internal data prep function for the context, but one thing at a time.

AltOutcome is in its own file to avoid cyclical imports. Actions point to sheets in their metadata, which makes things rather tricky for import order. Any action sheet importing from the damage field file directly will cause an error on startup.

@CarlosFdez CarlosFdez changed the base branch from main to feature/granular-action-outcomes May 16, 2026 02:46
@CarlosFdez CarlosFdez changed the title Umbrella outcomes Lift definition of alt outcomes up one step May 16, 2026
@moliloo moliloo added the enhancement New feature or request label May 23, 2026
@CarlosFdez
Copy link
Copy Markdown
Contributor Author

This is a merge to Harry's PR, so the one that decides is Harry I imagine once he's happy to return to it.

@WBHarry
Copy link
Copy Markdown
Contributor

WBHarry commented May 24, 2026

Yah, I'm going to check on this again sometime soon. I've gotten a bit more thoughtful about the whole thing due to a few things. But lifting it up like this so Effects and Damage can be under the same level should definately be a good thing regardless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants