[Feature] Configurable starting gold amounts in Homebrew settings#1969
Open
TrezzeIohan wants to merge 3 commits into
Open
[Feature] Configurable starting gold amounts in Homebrew settings#1969TrezzeIohan wants to merge 3 commits into
TrezzeIohan wants to merge 3 commits into
Conversation
Contributor
|
Hello, thank you for working on the PR. The idea seems sound, though I have a few observations.
|
Added `initialAmount` field to each currency type (coins, handfuls, bags, chests)
in the Homebrew settings schema. Defaults match book values (0, 1, 0, 0).
- Homebrew.mjs: added `initialAmount` NumberField per currency; `_initializeSource`
coerces empty submissions to 0; `refreshConfig()` syncs values to
`CONFIG.DH.RESOURCE.character.initialCurrency`
- resourceConfig.mjs: added mutable `initialCurrency` object on `character` export
- actorField.mjs: added `CharacterGoldField` subclass that reads initial values
from config at actor creation time
- character.mjs: switched from `GoldField` to `CharacterGoldField`
- settings.hbs: restructured currency section to CSS Grid with column headers
("Quantity Name" / "Starting Amount") instead of per-field inline labels
- settings.less: added `.currency-rows` grid styles
- en.json: added `quantityName` and `initialAmount` localisation keys
- Disabled denominations now receive 0 at character creation - Replace CharacterGoldField subclass with GoldField options callback; initial value logic now lives in character.mjs - Use formInput instead of plain text inputs for denomination labels - Rename "Quantity Name" column header to "Denomination" - Remove initialCurrency from resourceConfig and currency sync from refreshConfig (no longer needed)
7c84de6 to
83b25f4
Compare
Author
|
@CarlosFdez Thank you so much for your feedback! I've addressed all the points you raised. Please feel free to leave any further comments. [Fix] Address PR review feedback for starting gold feature
|
CarlosFdez
reviewed
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, guys! This is my first time contributing to a project; any feedback is appreciated.
This pull request aims to solve issue #734
Added
initialAmountfield to each currency type (coins, handfuls, bags, chests) in the Homebrew settings schema. Defaults match book values (0, 1, 0, 0).initialAmountNumberField per currency;_initializeSourcecoerces empty submissions to 0;refreshConfig()syncs values toCONFIG.DH.RESOURCE.character.initialCurrencyinitialCurrencyobject oncharacterexportCharacterGoldFieldsubclass that reads initial values from config at actor creation timeGoldFieldtoCharacterGoldField.currency-rowsgrid stylesquantityNameandinitialAmountlocalisation keys