[Fix] visual quirk with blur in unfocused countdown#1970
Merged
Conversation
Contributor
Author
|
I snuck in a minor fix for icon only mode and some refactors to make it scale with font size. I also replace id for data-countdown, since id is meant to be used once only on the entire DOM. I also replaced the events with the onX names we talked about. |
WBHarry
approved these changes
Jun 4, 2026
Contributor
WBHarry
left a comment
WBHarry
left a comment
There was a problem hiding this comment.
Scrollbar begone 🪄
Nice standardisation of action names and reducing to a single Id value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than blur being applied on header/content separately, its applied on the outermost div. This avoids the weird "dividing line" in the blur that occurs when an image is under it.