Allow encoding data with missing fields.#50
Allow encoding data with missing fields.#50FourierTransformer merged 8 commits intoFourierTransformer:masterfrom
Conversation
|
Ahhh yeah, that makes sense and looks good overall! I think maybe it should be changed to Oh and maybe add a few unit tests. I'm assuming it also works with the |
|
In my implementation it works with |
|
I added a unit test; it only runs on a dedicated CSV/JSON pair because otherwise it breaks |
|
All the tests pass on the main branch: https://github.com/FourierTransformer/ftcsv/actions/runs/17284534932/job/49059071095. I have no intention of changing existing behaviour, and no plans for a major release, so at the moment there can't be any breaking changes to exisitn tests. You may want to look into what's causing the failures. Also, I think you may have accidentally included other new options |
|
Oops, I'm sorry, those were options I was experimenting with and that weren't completed. I will remove them. |
|
Tests pass now. Is anything else missing for approving this PR? |
|
Nope, it's looking good, thanks! |
17cc241
into
FourierTransformer:master
|
Hi, thanks for merging this. I have been using a locally built rock and it works fine. Are you planning a new Luarocks release soon? I'll be releasing a rock that depends on these changes some time soon and it would be good to have the dependency pulled automatically instead of asking the installers to build ftcsv separately from the master branch. Thanks! |
This small PR allows encoding CSV from data entirely missing a field that was indicated in the
fieldsToKeepoption.Useful when encoding multiple data sets into similarly formatted CSV files.