Skip to content

Translate javascript-algorithms-and-data-structures-projects #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LynnLian wants to merge 28 commits into from
Closed

Translate javascript-algorithms-and-data-structures-projects #8

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
f78814b
Progress: 1 / 22
Jul 20, 2018
41acf6f
Progress: 1 / 22
Jul 21, 2018
18c8fc7
Progress: 2 / 22
Jul 21, 2018
8aca09a
按以下规则修改用词：
Jul 21, 2018
6f6a563
算法和数据结构 - 项目实践 （1/5)
Jul 22, 2018
62ce95f
Merge branch 'translate' of github.com:freeCodeCampChina/challenges i…
Jul 22, 2018
d47c172
算法和数据结构 - 项目实践 （2/5)
Jul 22, 2018
e1f2d8a
Caesars Cipher
Jul 22, 2018
b3d19a1
Merge branch 'translate' of https://github.com/freeCodeCampChina/chal…
Jul 24, 2018
aa4dae5
修改1，2，3部分在pr的comment。
Jul 24, 2018
ae6b6cf
Telephone Number Validator
Jul 24, 2018
f004ea8
revert commit f78814b6c5cf1c70992e629531065b256eb95bca
Jul 25, 2018
a0a0aef
Add .gitignore, including patterns for OS, Vim, VSCode, Jetbrains and…
S1ngS1ng Jul 25, 2018
7dc217c
Translation of intermediate-algorithm-scripting, 50% (#11)
S1ngS1ng Jul 26, 2018
0b9612d
Add CONTRIBUTING.md (#15)
S1ngS1ng Jul 26, 2018
044f83b
Update .gitignore that captures .vscode.*\.json (#28)
S1ngS1ng Jul 27, 2018
1ecae28
Fix (#29)
huluoyang Jul 27, 2018
9e8c003
(WIP) style-guide (#33)
S1ngS1ng Jul 28, 2018
fdc9758
Translate managing-packages-with-npm (#1)
ifyour Jul 28, 2018
d075968
Translate responsive-web-design-projects (#2)
XERO75 Jul 28, 2018
a995b32
Translate information-security-with-helmet (#4)
stanleyyylau Jul 28, 2018
beb6af1
Translate object-oriented-programming (#12)
XiaoLuo01 Jul 28, 2018
035a81c
Translate basic-css (#17)
focus-kfc Jul 28, 2018
d9f3b01
Css grid (#30)
stevending1st Jul 28, 2018
7e8fa97
responsive-web-design-principles translate (#35)
rainpure Jul 28, 2018
04bd22e
更新：翻译格式与建议 (#37)
S1ngS1ng Jul 29, 2018
c22c82a
修改：
Jul 30, 2018
93ffab0
Cash Register
Jul 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions 01-responsive-web-design/css-grid.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@
"id": "5a858944d96184f06fd60d61",
"title": "Create Your First CSS Grid",
"description": [
"Turn any HTML element into a grid container by setting its <code>display</code> property to <code>grid</code>. This gives you the ability to use all the other properties associated with CSS Grid.",
"<strong>Note</strong><br>In CSS Grid, the parent element is referred to as the <dfn>container</dfn> and its children are called <dfn>items</dfn>.",
"为了令 HTML 元素包含在网格容器中，可将 <code>display</code> 的属性值设置为 <code>grid</code> 。此后，你将可以使用关于 CSS 的不同网格特性。",
Copy link
Contributor

@S1ngS1ng S1ngS1ng Jul 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里似乎漏掉了 any 的翻译，应为 任何 HTML 元素。

另外，建议改一下语序：
对于任何 HTML 元素，如果我们把它的 <code>display</code> 的属性值设置为 <code>grid</code>，那么它就成为了一个网格容器。

对于半角符号、数字、英文字母之后是全角符号的情况，则不需要加空格。

此后，你将可以使用关于 CSS 的不同网格特性。 建议改成：
然后，你就可以调用 CSS 网格的其他属性。

"<strong>敲黑板：</strong><br>在 CSS 网格中, 父元素可被视为 <dfn>container</dfn> 。那么他的子元素被称为 <dfn>items</dfn> 。",
Copy link
Contributor

@S1ngS1ng S1ngS1ng Jul 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“敲黑板” 很优秀 😂 不过为了整体统一，换成“注意” 吧。
请参考：https://github.com/FreeCodeCampChina/curriculum-cn/pull/12/files 最好能保证你们的翻译中，术语也是一致的

请改一下这里的逗号，应当使用全角逗号。

父元素可被视为 <dfn>container</dfn> 。那么他的子元素被称为 <dfn>items</dfn> 。 建议改成：
父元素叫做 <dfn>container</dfn>，而它的子元素叫 <dfn>items</dfn>。

注意这里的 而 不表示转折关系

"<hr>",
"Change the display of the div with the <code>container</code> class to <code>grid</code>."
"在包含以 <code>container</code> 为 class 的 div 中 ，把其中的 display 属性值设置为 grid。"
Copy link
Contributor

@S1ngS1ng S1ngS1ng Jul 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不要把 grid 外面的 <code></code> 删掉

在包含以 <code>container</code> 为 class 的 div 中 ， =>
在 class 为 <code>container</code> 的 div 中 ，

],
"tests": [
{
"text": "<code>container</code> class should have a <code>display</code> property with a value of <code>grid</code>.",
"text": "在名为 <code>container</code> 的 class 中，其 <code>display</code> 属性值应被设置为 <code>grid</code> 。",
Copy link
Contributor

@S1ngS1ng S1ngS1ng Jul 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

类似上面的翻译，class 为 <code>container</code> 的元素，其 <code>display</code> 属性值应被设置为 <code>grid</code> 。

"testString": "assert(code.match(/.container\\s*?{[\\s\\S]*display\\s*?:\\s*?grid\\s*?;[\\s\\S]*}/gi), '<code>container</code> class should have a <code>display</code> property with a value of <code>grid</code>.');"
Copy link
Contributor

@S1ngS1ng S1ngS1ng Jul 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里也是要翻译的噢，翻译第二个参数就好啦

}
],
Expand Down