Skip to content

STM32H legacy driver fix: request usable RX size in legacy zero-copy #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liteStefanoUgolini wants to merge 1 commit into
base: main
Choose a base branch
from
Open

STM32H legacy driver fix: request usable RX size in legacy zero-copy #1328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions source/portable/NetworkInterface/STM32/Legacy/STM32Hxx/NetworkInterface.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -780,8 +780,9 @@ static BaseType_t prvNetworkInterfaceInput( void )

#if ( ipconfigZERO_COPY_RX_DRIVER != 0 )
{
/* Reserve the maximum length for the next reception. */
uxLength = ETH_RX_BUF_SIZE;
/* Request the usable Ethernet payload area, excluding the descriptor
* metadata stored in front of pucEthernetBuffer. */
uxLength = ETH_RX_BUF_SIZE - ipBUFFER_PADDING;
Copy link
Copy Markdown
Contributor

@htibosch htibosch Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds like a good change, thank you.

The sizeof of the RX buffer is usually set at :

#define ETH_RX_BUF_SIZE     1536U

because it has a great alignment ( 0x600 ).

@AniruddhaKanhere @kstribrnAmzn Can you please check this PR?

Copy link
Copy Markdown
Member

@kstribrnAmzn kstribrnAmzn Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course!


if( data_buffer.buffer != NULL )
{
Expand Down