removed "s" in base platform as it is just wrong for matching#17
Open
kinkerl wants to merge 1 commit intoFriendCode:masterfrom
kinkerl:master
Open
removed "s" in base platform as it is just wrong for matching#17kinkerl wants to merge 1 commit intoFriendCode:masterfrom kinkerl:master
kinkerl wants to merge 1 commit intoFriendCode:masterfrom
kinkerl:master
Conversation
|
Hey @kinkerl, You might also want to have a look at the following two libraries we have been using for parsing git URLs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
base platform would only match if every token ends with an "s". this is now fixed