chore(charts): bump visx to v4 for React 19 compatibility - #2812
Merged
Conversation
🦋 Changeset detectedLatest commit: 8f37761 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
noahwaldner
approved these changes
Jul 27, 2026
✅ Deploy Preview for fondue-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
charlietango
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps all
@visx/*dependencies in@frontify/fondue-chartsfrom^3.12.0to^4.0.0. visx was one of the remaining deps blocking React 19 (v3 peers only allow React 16–18; v4 allows 18 or 19). The package's own peer range staysreact: ^18— widening it is a separate, fondue-wide step.Changes
@visx/*→ ^4.0.0 (11 runtime deps +@visx/mock-data).@react-spring/web: ^10.1.2— it's a required peer of@visx/xychartthat was never declared anywhere; we'd been silently relying on pnpm'sautoInstallPeers, which had resolved a stale 9.7.3. v4 requires^9.7.5 || ^10; the v10 line is the one that also supports React 19, so pinning 9.x would recreate the same blocker one level deeper.exportsmaps, so deeplib/imports no longer resolve:TooltipInPortalPropsnow imported from the@visx/tooltiproot (re-exported there)PieArcDatumnow imported fromd3-shape(visx's type is a direct alias of it; matches existing d3-shape type imports in the same files)TooltipDatumdefined locally ingetTooltipEntries.ts(no longer exported by@visx/xychart)<rect> attribute height: A negative value is not valid) —SeriesClipPathcomputed clip rect heights from scales beforeParentSizemeasured the container; visx 4's reworked responsive internals surfaced the unguarded math on the first render frame. Geometry is now clamped to ≥ 0; settled renders are unaffected. Also removes three@ts-expect-errordirectives by reading scale ranges via destructuring-with-defaults.:focus(not:focus-visible), so thetabIndexarcs rang on click. Pre-existing behavior (v3 identical), fixed while in here: outline suppressed for:focus:not(:focus-visible), keyboard focus ring unchanged.