feat(DoDontBlock): extracted the toolbar - #1393
Merged
benfrontify merged 12 commits intoJul 23, 2026
Merged
Conversation
benfrontify
changed the title
ragi96
reviewed
Jul 14, 2026
Contributor
Author
|
I’m not quite sure which naming convention I should use. I followed your latest review because DoDont seems more reasonable than DosDont, which was suggested in the first review. Please let me know if I should change it. |
Contributor
Author
|
i wold have done DosDonts but idk |
ragi96
reviewed
Jul 14, 2026
ragi96
reviewed
Jul 17, 2026
ragi96
requested changes
Jul 21, 2026
ragi96
reviewed
Jul 21, 2026
ragi96
reviewed
Jul 22, 2026
ragi96
reviewed
Jul 23, 2026
ragi96
approved these changes
Jul 23, 2026
benfrontify
deleted the
gcm-203-add-file-dosdontstoolbartsx-dosdontsitemstsx
branch
July 23, 2026 13:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extracted the toolbar from DoDontItem