-
Notifications
You must be signed in to change notification settings - Fork 1
Develop #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feat/#15 home component
…tecture Feat/#1 component architecture
…tecture [fix] import 대소문자 이슈 해결
…tecture #1 [fix] ...
#15 [feat] Home 화면 카드 종목명 추가
#15 [feat] 홈화면 카드 이미지 클릭시 검색 화면 이동
#15 [feat] 홈화면 카드 리스트 일부 구현
#15 [feat] 스타일링 적용 및 메인레이아웃 수정
#15 [feat] 홈화면 가로스크롤 구현 완료
#15 [fix] esint airbnb 제거
#15 [feat] 국내/해외 메뉴탭 구현
Jadest13
approved these changes
Nov 21, 2024
Collaborator
Jadest13
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 타입(하나 이상의 PR 타입을 선택해주세요)
반영 브랜치
dev -> main
변경 사항
MVP 배포를 위한 테스트
테스트 결과
ex) 베이스 브랜치에 포함되기 위한 코드는 모두 정상적으로 동작해야 합니다. 결과물에 대한 스크린샷, GIF, 혹은 라이브 데모가 가능하도록 샘플API를 첨부할 수도 있습니다.