Skip to content

Fixed "No External Storage Permission" on first run and bad state of application #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Remzoo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed "No External Storage Permission" on first run and bad state of application #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions .idea/libraries/Gradle__com_android_support_support_compat_24_2_0.xml
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions .idea/libraries/Gradle__com_android_support_support_core_ui_24_2_0.xml
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions .idea/libraries/Gradle__com_android_support_support_core_utils_24_2_0.xml
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions .idea/libraries/Gradle__com_android_support_support_fragment_24_2_0.xml
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions .idea/libraries/Gradle__com_android_support_support_media_compat_24_2_0.xml
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions .idea/libraries/Gradle__com_android_support_support_v4_24_2_0.xml
View file
Open in desktop

This file was deleted.

8 changes: 4 additions & 4 deletions src/uk/ac/swansea/eduroamcat/EAPMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ public class EAPMetadata extends Activity {
//global clietn cert value for retry
static NodeList clientCert;
private static final int MY_PERMISSIONS_REQUEST_WRITE_EXTERNAL_STORAGE = 0;
private boolean configFileError = false;

public boolean testExternalStorage()
{
Expand All @@ -80,8 +81,9 @@ public void onRequestPermissionsResult(int requestCode, String permissions[], in
this.recreate();
} else {
Toast.makeText(this, this.getString(R.string.storagePermission), Toast.LENGTH_LONG).show();
configFileError = true;
finish();
}
return;
}
}
}
Expand All @@ -99,7 +101,7 @@ protected void onCreate(Bundle savedInstanceState) {
setContentView(R.layout.activity_eapmetadata);
Intent configIntent = getIntent();
InputStream configIn = null;
boolean configFileError = false;

String pathToDownload ="";
eduroamCAT.debug("Got eap-config:"+configIntent.getDataString());

Expand All @@ -109,8 +111,6 @@ protected void onCreate(Bundle savedInstanceState) {
ActivityCompat.requestPermissions(this,
new String[]{Manifest.permission.WRITE_EXTERNAL_STORAGE},
MY_PERMISSIONS_REQUEST_WRITE_EXTERNAL_STORAGE);
configFileError=true;
Toast.makeText(this, this.getString(R.string.storagePermission), Toast.LENGTH_LONG).show();
}
else configFileError=false;

Expand Down