Improve the GMM testing by leveraging the SMT#45
Open
CB-quakemodel wants to merge 26 commits intomasterfrom
Open
Improve the GMM testing by leveraging the SMT#45CB-quakemodel wants to merge 26 commits intomasterfrom
CB-quakemodel wants to merge 26 commits intomasterfrom
Conversation
CB-quakemodel
force-pushed
the
gmm_testing
branch
from
5d1219f to
fb86e36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand the initial GMM testing to compute per GMM per TRT the total, inter and intra-event residuals and some overall summary plots too. Addresses #20
I extend the same ContextDB used in the SMT so we can use the SMT's existing capabilities to compute the partitioned random effects residuals. We can also then use the plotting functions to provide some summary plots of the residuals too. Right now it is hardcoded to compute the GRM IMTs (PGA, SA(0.3), SA(0.6) and SA(1.0)).
Examples of the plots are provided here (these are the ones generated in the added unit test for the new residual analysis functions - note that I made a fake ground-motion dataset for each TRT given there is not any available ground-motions for the region covered by the source model used in the SSC testing QA). This is made clear in the sample flatfile to ensure a user does not think this is real metadata for ground-motions in the test SSC area.
I have updated the generation of the residual analysis HTML and the documentation.
This PR will break the current tests because we need the MBTK installed in the same environment as the CI tests create
Example plot: