Skip to content

Feat: Change to local Newell's normal #3977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jafranc wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Feat: Change to local Newell's normal #3977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c55660
try local newell
jafranc Feb 15, 2026
e1996b1
Local Newell / debug
jafranc Feb 16, 2026
2129e1f
clean up
jafranc Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions src/coreComponents/mesh/unitTests/testComputationalGeometry.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
* @file testComputationalGeometry.cpp
*/
#include "../utilities/ComputationalGeometry.hpp"
#include <cmath>
#include <gtest/gtest.h>
#include <numeric>

Expand Down Expand Up @@ -70,4 +71,58 @@ TEST( testComputationalGeometry, checkCentroid3DPolygon )
}
}

TEST( testComputationalGeometry, checkHighAspectRatio)
{
constexpr localIndex numNodes = 3;

array2d< real64, nodes::REFERENCE_POSITION_PERM > points;
points.resize(numNodes, 3);
array1d< localIndex > indices(3);
indices(0) = 0;
indices(1) = 1;
indices(2) = 2;

//mimic a perfect triangle but with huge offset
constexpr real64 xa = 1.e4, ya = 1.e-2, za = 1.e0;
constexpr real64 xb = 1.e-1, yb = 1.e2, zb = -1.e-2;
constexpr real64 TOL = 1e-6;

points(0,0) = 1.e6;
points(0,1) = 1.e6;
points(0,2) = 1.e6;

points(1,0) = 1.e6 + xa;
points(1,1) = 1.e6 + ya;
points(1,2) = 1.e6 + za;

points(2,0) = 1.e6 + xb;
points(2,1) = 1.e6 + yb;
points(2,2) = 1.e6 + zb;

real64 faceCenter[ 3 ], faceNormal[ 3 ];
real64 faceCenterOld[ 3 ], faceNormalOld[ 3 ];
auto faceArea = computationalGeometry::centroid_3DPolygon(indices.toSliceConst(), points.toViewConst(), faceCenter, faceNormal, TOL);

constexpr real64 EXPECTED_AREA = 0.5*std::sqrt(LvArray::math::square(xa*yb-ya*xb) +
LvArray::math::square(ya*zb-za*yb) +
LvArray::math::square(za*xb-xa*zb) );

constexpr real64 EXPECTED_CENTER[3] = { 1.e6 + (xa+xb)/3 , 1.e6 + (ya+yb)/3. , 1.e6 + (za+zb)/3};

constexpr real64 EXPECTED_NORMAL[3] = { (ya*zb-za*yb)/2/EXPECTED_AREA, (za*xb-xa*zb)/2/EXPECTED_AREA, (xa*yb-ya*xb)/2/EXPECTED_AREA};

EXPECT_LT( abs(faceArea - EXPECTED_AREA), 1e-6);
EXPECT_LT( abs(faceNormal[0]-EXPECTED_NORMAL[0]), 1e-6);
EXPECT_LT( abs(faceNormal[1]-EXPECTED_NORMAL[1]), 1e-6);
EXPECT_LT( abs(faceNormal[2]-EXPECTED_NORMAL[2]), 1e-6);
EXPECT_LT( abs(faceCenter[0]-EXPECTED_CENTER[0]), 1e-6);
EXPECT_LT( abs(faceCenter[0]-EXPECTED_CENTER[0]), 1e-6);
EXPECT_LT( abs(faceCenter[1]-EXPECTED_CENTER[1]), 1e-6);
EXPECT_LT( abs(faceCenter[2]-EXPECTED_CENTER[2]), 1e-6);

real64 norm = LvArray::math::square( faceNormal[0] ) + LvArray::math::square( faceNormal[1] ) + LvArray::math::square( faceNormal[2] );
EXPECT_LT(abs( sqrt( norm ) - 1.0 ), 1e-6);

}

} /* namespace geos */
14 changes: 9 additions & 5 deletions src/coreComponents/mesh/utilities/ComputationalGeometry.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ real64 computeDiameter( POINT_COORDS_TYPE points,
}

/**
* @brief Calculate the centroid of a convex 3D polygon as well as the normal and the rotation matrix.
* @brief Calculate the centroid of a convex 3D polygon as well as the normal.
* @tparam CENTER_TYPE The type of @p center.
* @tparam NORMAL_TYPE The type of @p normal.
* @param[in] pointsIndices list of index references for the points array in
Expand Down Expand Up @@ -245,14 +245,17 @@ real64 centroid_3DPolygon( arraySlice1d< localIndex const > const pointsIndices,

GEOS_ERROR_IF_LT( numberOfPoints, 2 );

real64 current[ 3 ], next[ 3 ], crossProduct[ 3 ];
real64 current[ 3 ], next[ 3 ], origin[ 3 ], crossProduct[ 3 ];

LvArray::tensorOps::copy< 3 >( next, points[ pointsIndices[ numberOfPoints - 1 ] ] );
LvArray::tensorOps::copy< 3>( origin, points[ pointsIndices[ 0 ]] );

for( localIndex a=0; a<numberOfPoints; ++a )
for( localIndex a=0; a<numberOfPoints; )
{
LvArray::tensorOps::copy< 3 >( current, next );
LvArray::tensorOps::copy< 3 >( next, points[ pointsIndices[ a ] ] );
LvArray::tensorOps::copy< 3 >( current, points[ pointsIndices[ a++ ]] );
LvArray::tensorOps::scaledAdd<3>(current, origin, -1.);
LvArray::tensorOps::copy< 3 >( next, points[ pointsIndices[ a % numberOfPoints ] ] );
LvArray::tensorOps::scaledAdd<3>(next, origin, -1.);

LvArray::tensorOps::crossProduct( crossProduct, current, next );

Expand All @@ -262,6 +265,7 @@ real64 centroid_3DPolygon( arraySlice1d< localIndex const > const pointsIndices,

area = LvArray::tensorOps::l2Norm< 3 >( normal );
LvArray::tensorOps::scale< 3 >( center, 1.0 / numberOfPoints );
LvArray::tensorOps::scaledAdd< 3 >( center, origin, 1. );

if( area > areaTolerance )
{
Expand Down
Loading