-
Notifications
You must be signed in to change notification settings - Fork 13
Added metabase to shared terraform modules #5299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This pull request is not up to date with main. Please merge main into this brach or rebase this branch onto main. This PR should not be approved until all status checks pass. If you see this message, please rerun all status checks before merging. |
|
Terraform plan for meta No changes. Your infrastructure matches the configuration.📝 Plan generated in Pull Request Checks #271 |
|
Terraform plan for dev Plan: 4 to add, 0 to change, 1 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
-/+ destroy and then create replacement
<= read (data resources)
Terraform will perform the following actions:
# module.dev.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~ id = "*******************" -> (known after apply)
!~ triggers = { # forces replacement
!~ "always_run" = "2026-01-16T12:53:14Z" -> (known after apply)
}
}
# module.dev.module.metabase-app.data.cloudfoundry_domain.public will be read during apply
# (depends on a resource or a module with changes pending)
<= data "cloudfoundry_domain" "public" {
+ annotations = (known after apply)
+ created_at = (known after apply)
+ id = (known after apply)
+ internal = (known after apply)
+ labels = (known after apply)
+ name = "app.cloud.gov"
+ org = (known after apply)
+ router_group = (known after apply)
+ shared_orgs = (known after apply)
+ supported_protocols = (known after apply)
+ updated_at = (known after apply)
}
# module.dev.module.metabase-app.data.cloudfoundry_org.app_org will be read during apply
# (depends on a resource or a module with changes pending)
<= data "cloudfoundry_org" "app_org" {
+ annotations = (known after apply)
+ created_at = (known after apply)
+ id = (known after apply)
+ labels = (known after apply)
+ name = "gsa-tts-oros-fac"
+ quota = (known after apply)
+ suspended = (known after apply)
+ updated_at = (known after apply)
}
# module.dev.module.metabase-app.data.cloudfoundry_space.app_space will be read during apply
# (config refers to values not yet known)
<= data "cloudfoundry_space" "app_space" {
+ allow_ssh = (known after apply)
+ annotations = (known after apply)
+ created_at = (known after apply)
+ id = (known after apply)
+ isolation_segment = (known after apply)
+ labels = (known after apply)
+ name = "dev"
+ org = (known after apply)
+ quota = (known after apply)
+ updated_at = (known after apply)
}
# module.dev.module.metabase-app.data.docker_registry_image.metabase will be read during apply
# (depends on a resource or a module with changes pending)
<= data "docker_registry_image" "metabase" {
+ id = (known after apply)
+ name = "metabase/metabase:latest"
+ sha256_digest = (known after apply)
}
# module.dev.module.metabase-app.cloudfoundry_app.metabase will be created
+ resource "cloudfoundry_app" "metabase" {
+ buildpacks = (known after apply)
+ command = <<-EOT
MB_DB_CONNECTION_URI=$(echo "$VCAP_SERVICES" | grep -o '"uri":\s*"[^"]*' | sed 's/"uri":\s*//' | cut -d '"' -f2 | tail -1)
export MB_DB_CONNECTION_URI
./app/run_metabase.sh
EOT
+ created_at = (known after apply)
+ disk_quota = "3072M"
+ docker_image = (known after apply)
+ enable_ssh = (known after apply)
+ environment = {
+ "ENV" = "dev"
+ "REQUESTS_CA_BUNDLE" = "/etc/ssl/certs/ca-certificates.crt"
+ "SSL_CERT_FILE" = "/etc/ssl/certs/ca-certificates.crt"
}
+ health_check_http_endpoint = "/api/health"
+ health_check_type = "http"
+ id = (known after apply)
+ instances = 1
+ log_rate_limit_per_second = (known after apply)
+ memory = "2048M"
+ name = "metabase"
+ org_name = "gsa-tts-oros-fac"
+ readiness_health_check_type = (known after apply)
+ routes = (known after apply)
+ service_bindings = [
+ {
+ params = jsonencode({})
+ service_instance = "fac-db"
},
+ {
+ params = jsonencode({})
+ service_instance = "https-proxy-creds"
},
+ {
+ params = jsonencode({})
+ service_instance = "metabase-db"
},
]
+ space_name = "dev"
+ stack = (known after apply)
+ strategy = "rolling"
+ updated_at = (known after apply)
}
# module.dev.module.metabase-app.cloudfoundry_route.app_route will be created
+ resource "cloudfoundry_route" "app_route" {
+ created_at = (known after apply)
+ destinations = [
+ {
+ app_id = (known after apply)
+ app_process_type = (known after apply)
+ id = (known after apply)
+ port = (known after apply)
+ protocol = (known after apply)
},
]
+ domain = (known after apply)
+ host = "metabase-dev"
+ id = (known after apply)
+ protocol = (known after apply)
+ space = (known after apply)
+ updated_at = (known after apply)
+ url = (known after apply)
}
# module.dev.module.metabasedb.cloudfoundry_service_instance.rds will be created
+ resource "cloudfoundry_service_instance" "rds" {
+ created_at = (known after apply)
+ dashboard_url = (known after apply)
+ id = (known after apply)
+ last_operation = (known after apply)
+ maintenance_info = (known after apply)
+ name = "metabase-db"
+ parameters = (sensitive value)
+ service_plan = "815c6069-289a-4444-ba99-40f0fa03a8f5"
+ space = "06525ba3-19c2-451b-96e9-ea4a9134e8b9"
+ tags = [
+ "rds",
+ "terraform-cloudgov-managed",
]
+ type = "managed"
+ updated_at = (known after apply)
+ upgrade_available = (known after apply)
}
Plan: 4 to add, 0 to change, 1 to destroy.📝 Plan generated in Pull Request Checks #271 |
|
jperson1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems right to me. Moving it along!
PR Checklist: Submitter
maininto your branch shortly before creating the PR. (You should also be mergingmaininto your branch regularly during development.)git status | grep migrations. If there are any results, you probably need to add them to the branch for the PR. Your PR should have only one new migration file for each of the component apps, except in rare circumstances; you may need to delete some and re-runpython manage.py makemigrationsto reduce the number to one. (Also, unless in exceptional circumstances, your PR should not delete any migration files.)PR Checklist: Reviewer
make docker-clean; make docker-first-run && docker compose up; then rundocker compose exec web /bin/bash -c "python manage.py test"The larger the PR, the stricter we should be about these points.
Pre Merge Checklist: Merger
-/+ resource "null_resource" "cors_header"should be destroying and recreating its self and~ resource "cloudfoundry_app" "clamav_api"might be updating itssha256for thefac-file-scannerandfac-av-${ENV}by default.main.