Fix question position gaps in Touchpoints API responses#1883
Draft
Fix question position gaps in Touchpoints API responses#1883
Conversation
Author
|
@rileyseaburg 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: rileyseaburg <48305658+rileyseaburg@users.noreply.github.com>
Co-authored-by: rileyseaburg <48305658+rileyseaburg@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Touchpoints API Question Positions are incorrect
Fix question position gaps in Touchpoints API responses
Aug 19, 2025
Contributor
|
copilot has entered the chat |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Touchpoints API was returning non-sequential question positions when questions had been deleted from forms. For example, a form with 6 questions would return positions like
[1, 3, 5, 6, 7, 16]instead of the expected sequential values[1, 2, 3, 4, 5, 6].This occurred because:
questionsassociation which preserves these database position values with gapsSolution:
QuestionSerializerthat normalizes position values to be sequential starting from 1FormSerializerandFullFormSerializerto use the new serializerordered_questionsmethod which returns questions in the correct order across form sectionsExample of the fix:
The change is backward compatible and only affects the API response format - the underlying database positions remain unchanged to preserve form structure integrity.
Fixes #1876.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.