Conversation
Contributor
Author
|
@CookiePLMonster can you review? |
CookiePLMonster
approved these changes
Jan 10, 2026
Member
CookiePLMonster
left a comment
CookiePLMonster
left a comment
There was a problem hiding this comment.
Added a few nitpicks about the CI script, but overall it's just fine. My main worry was that the DLL would link against vcruntime.dll but it does not, so it's all good.
This reverts commit f1f1d07.
Contributor
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had to link two extra CRT libs to build on modern MSVC.