Skip to content

Sanqueen is assymetric#14

Open
peblpebl wants to merge 1 commit intoGaiaByte:masterfrom
peblpebl:patch-4
Open

Sanqueen is assymetric#14
peblpebl wants to merge 1 commit intoGaiaByte:masterfrom
peblpebl:patch-4

Conversation

@peblpebl
Copy link
Contributor

@peblpebl peblpebl commented May 8, 2019

Sanqueen's code checks that she is alive before applying leech. However the check is sort of wrong, as the two sides takes turn to fight. So the first to go will not see her as dead (yet) and apply heal. That heal will go to the next unit. However the second to go will see her as dead and not apply the heal to next unit.

I dont see an easy solution with current code.

  1. Either remove the check, so she always heal next unit (strange, but fair).
  2. Stop removing dead units in subturns.

Patch for 1)

Sanqueen code checks that she is alive before applying leech. However the check is sort of wrong, as the two sides takes turn to fight. So the to go will not see her as dead (yet) and apply heal. That heal will go to the next unit. However the second to go will see her as dead and not apply the heal to next unit. 

I dont see an easy solution with current code. 
1) Either remove the check, so she always heal next unit (strange, but fair).
2) Stop removing dead units in subturns.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant