fix: do not draw from pixel for InterpolatedImage photon shooting#231
Merged
Conversation
Merging this PR will improve performance by 33.67%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | test_benchmarks_lanczos_interp[xval-no_conserve_dc-run] |
1,107.6 µs | 828.7 µs | +33.67% |
Comparing test-thresh-1 (ed69e21) with main (58bb47e)
beckermr
marked this pull request as ready for review
May 7, 2026 19:14
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug for photon shooting for interpolated images. I had coded it up to draw uniformly from the pixel of the interpolated image and then convolve in the interpolant kernel. That is wrong and instead it should simply treat the original image as a set of delta functions.
Working on comment https://github.com/GalSim-developers/GalSim-for-JAX-GalSim-Testing/pull/1/changes#r3028386824