Skip to content

fix: do not draw from pixel for InterpolatedImage photon shooting#231

Merged
beckermr merged 3 commits into
mainfrom
test-thresh-1
May 7, 2026
Merged

fix: do not draw from pixel for InterpolatedImage photon shooting#231
beckermr merged 3 commits into
mainfrom
test-thresh-1

Conversation

@beckermr

@beckermr beckermr commented May 7, 2026

Copy link
Copy Markdown
Collaborator

This PR fixes a bug for photon shooting for interpolated images. I had coded it up to draw uniformly from the pixel of the interpolated image and then convolve in the interpolant kernel. That is wrong and instead it should simply treat the original image as a set of delta functions.

Working on comment https://github.com/GalSim-developers/GalSim-for-JAX-GalSim-Testing/pull/1/changes#r3028386824

@codspeed-hq

codspeed-hq Bot commented May 7, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 33.67%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 35 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation test_benchmarks_lanczos_interp[xval-no_conserve_dc-run] 1,107.6 µs 828.7 µs +33.67%

Comparing test-thresh-1 (ed69e21) with main (58bb47e)

Open in CodSpeed

@beckermr beckermr changed the title test: figure out what fails with photon shooting fix: do not draw from pixel for InterpolatedImage photon shooting May 7, 2026
@beckermr

beckermr commented May 7, 2026

Copy link
Copy Markdown
Collaborator Author

cc @ismael-mendoza

@beckermr
beckermr merged commit 639f463 into main May 7, 2026
10 checks passed
@beckermr
beckermr deleted the test-thresh-1 branch May 7, 2026 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant