Skip to content

test: run full test suite with fixes from https://github.com/GalSim-developers/GalSim-for-JAX-GalSim-Testing/pull/7#232

Merged
beckermr merged 2 commits into
mainfrom
test-fixes-2
May 9, 2026
Merged

test: run full test suite with fixes from https://github.com/GalSim-developers/GalSim-for-JAX-GalSim-Testing/pull/7#232
beckermr merged 2 commits into
mainfrom
test-fixes-2

Conversation

@beckermr

@beckermr beckermr commented May 9, 2026

Copy link
Copy Markdown
Collaborator

As it says on the tin...

@codspeed-hq

codspeed-hq Bot commented May 9, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by ×2.1

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 11 improved benchmarks
✅ 25 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime test_benchmarks_lanczos_interp[kval-conserve_dc-run] 52 µs 30.4 µs +70.95%
WallTime test_benchmarks_lanczos_interp[kval-no_conserve_dc-run] 55.8 µs 30.6 µs +82.61%
WallTime test_benchmark_moffat_init[run] 97.8 µs 45.7 µs ×2.1
WallTime test_benchmarks_lanczos_interp[xval-no_conserve_dc-run] 114.7 µs 70.4 µs +63%
WallTime test_benchmarks_lanczos_interp[xval-conserve_dc-run] 127 µs 66.3 µs +91.6%
WallTime test_benchmark_invert_ab_noraise[run] 123.4 µs 91.6 µs +34.73%
WallTime test_benchmark_spergel_calcfluxrad[run] 213.8 µs 141.7 µs +50.86%
WallTime test_benchmark_spergel_kvalue[run] 11.6 ms 8.7 ms +32.94%
WallTime test_benchmark_spergel_init[run] 6.7 µs 5.1 µs +31.31%
WallTime test_benchmark_rng_discard[run] 119.1 µs 85.3 µs +39.63%
WallTime test_benchmark_interpimage_flux_frac[run] 442.9 µs 256.9 µs +72.42%

Comparing test-fixes-2 (7edc731) with main (639f463)

Open in CodSpeed

@beckermr
beckermr marked this pull request as ready for review May 9, 2026 10:15
@beckermr
beckermr enabled auto-merge (squash) May 9, 2026 10:16
@beckermr
beckermr disabled auto-merge May 9, 2026 10:17
@beckermr
beckermr merged commit 51aa901 into main May 9, 2026
8 checks passed
@beckermr
beckermr deleted the test-fixes-2 branch May 9, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant