Fix Unions of Enum-Coercable Types and Generics#66
Merged
smt5541 merged 2 commits intoGe0rg3:masterfrom Feb 7, 2026
Merged
Conversation
smt5541
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Changes being made
Fix bug where a union of a type that could be an enum (str | int) and a generic such as list or dict would result in the error
issubclass() arg 1 must be a class.Give examples of the changes you've made in this pull request. Include an itemized list if you can.
Check if the specific allowed type is a class before we actually make the issubclass check.
🧠 Rationale behind the change
Why did you choose to make these changes?
To fix a bug we were facing
Does this pull request resolve any open issues?
No
Were there any trade-offs you had to consider?
No
🧪 Testing
Have tests been added or updated for the changes introduced in this pull request?
Are the changes backwards compatible?
If the changes aren't backwards compatible, what other options were explored?
✨ Quality check
Are your changes free of any erroneous print statements, debuggers or other leftover code?
Has the README been updated to reflect the changes introduced (if applicable)?
💬 Additional comments