fix: Add validation to prevent arbitrary invoice status values#193
Open
Jean-Regis-M wants to merge 4 commits intoGenAI-Security-Project:mainfrom
Open
fix: Add validation to prevent arbitrary invoice status values#193Jean-Regis-M wants to merge 4 commits intoGenAI-Security-Project:mainfrom
Jean-Regis-M wants to merge 4 commits intoGenAI-Security-Project:mainfrom
Conversation
Add validation for invoice status before updating. Signed-off-by: JEAN REGIS <240509606@firat.edu.tr>
fix: Add validation to prevent arbitrary invoice status values
Signed-off-by: JEAN REGIS <240509606@firat.edu.tr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds input validation to
update_invoice_statusto ensure only predefinedstatus values can be persisted to the database.
Issue
Fixes #138
Changes Made
VALID_INVOICE_STATUSESconstant with allowed valuesupdate_invoice_statusValueErrorwith helpful message for invalid statusesTesting
test_inv_upd_005_arbitrary_status_acceptednow passes001-004) continue to passSecurity Impact
Prevents prompt injection attacks that could bypass business logic by
setting arbitrary status values (e.g., "approved_bypass" to avoid detection).