fix: validate risk_level in update_vendor_risk against allowed values#213
Open
Jean-Regis-M wants to merge 1 commit intoGenAI-Security-Project:mainfrom
Open
fix: validate risk_level in update_vendor_risk against allowed values#213Jean-Regis-M wants to merge 1 commit intoGenAI-Security-Project:mainfrom
Jean-Regis-M wants to merge 1 commit intoGenAI-Security-Project:mainfrom
Conversation
The update_vendor_risk function previously accepted any string as risk_level, including those with leading/trailing spaces (e.g., " low"). This allowed invalid data to be persisted, breaking downstream logic that expects exact matches for 'low', 'medium', or 'high'. Added a validation check using a set of allowed values. If the provided risk_level is not exactly one of the three, a ValueError is raised before any database operation occurs. This ensures data integrity and adheres to the function's documented contract. Fixes GenAI-Security-Project#181 Signed-off-by: JEAN REGIS <240509606@firat.edu.tr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds input validation to
update_vendor_riskto ensurerisk_levelis one of the allowed strings:'low','medium','high'.Problem
The function currently accepts any string (e.g.,
" low") and persists it directly, causing downstream fraud detection logic that relies on exact matches to fail. This can lead to silent data corruption and incorrect fraud assessments.Solution
VALID_RISK_LEVELS = {"low", "medium", "high"}.risk_levelis in this set.ValueErrorwith a clear message if validation fails.Impact
Testing
"low","medium","high"pass." low","low ","LOW",""all raiseValueError.test_fraud_upd_012_leading_space_risk_level_accepted_without_validationshould now pass.