Skip to content

fix: validate flag_reason in flag_invoice_for_review to reject None/empty #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jean-Regis-M wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: validate flag_reason in flag_invoice_for_review to reject None/empty #214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions finbot/tools/data/fraud.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,11 @@ async def flag_invoice_for_review(
Returns:
Dictionary containing flagged invoice details
"""
if flag_reason is None:
raise ValueError("flag_reason must not be None")
if not flag_reason.strip():
raise ValueError("flag_reason must not be empty or whitespace")

logger.info(
"Flagging invoice_id: %s for review. Reason: %s, Action: %s",
invoice_id,
Expand Down