fix(system-prompt-leak): handle assistant message content: null#254
Open
Jean-Regis-M wants to merge 1 commit intoGenAI-Security-Project:mainfrom
Open
fix(system-prompt-leak): handle assistant message content: null#254Jean-Regis-M wants to merge 1 commit intoGenAI-Security-Project:mainfrom
Jean-Regis-M wants to merge 1 commit intoGenAI-Security-Project:mainfrom
Conversation
Root cause:
When an assistant message contains "content": null (standard for tool-calling messages),
message.get("content", "") returns None because the key exists. Concatenating None to
a string raises TypeError, crashing the detector coroutine.
Solution:
Explicitly check for None before concatenation. If content is None, treat it as empty
string. This preserves the original behaviour for all other cases and prevents the crash.
Impact:
- Minimal, isolated change (only the assistant branch).
- No side effects; all existing tests pass.
- Critical fix because most real agent traffic includes tool calls with null content,
which would otherwise silently disable the detector after the first such event.
Signed-off-by: JEAN REGIS <240509606@firat.edu.tr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a crash in
SystemPromptLeakDetector._extract_textswhen an assistant message has"content": null.The detector now gracefully treats
nullas empty string.Problem
Issue #135: Test case DET‑SPL‑010 fails because the detector raises a
TypeErroron assistant messages withcontent: null.This occurs in normal operation whenever an agent makes a tool call, effectively disabling the detector after the first such event.
Root Cause
In
_extract_texts, the assistant branch uses: