fix(vendor): validate trust_level in update_vendor_status (fixes #235)#255
Open
Jean-Regis-M wants to merge 1 commit intoGenAI-Security-Project:mainfrom
Open
fix(vendor): validate trust_level in update_vendor_status (fixes #235)#255Jean-Regis-M wants to merge 1 commit intoGenAI-Security-Project:mainfrom
Jean-Regis-M wants to merge 1 commit intoGenAI-Security-Project:mainfrom
Conversation
…level in update_vendor_status
Root cause:
Missing input validation allowed any string (including those with spaces)
to be stored as trust_level, breaking downstream trust‑gated logic.
Solution:
Add a membership check against the set {"low", "standard", "high"} and
raise ValueError for invalid values. This rejects values like " standard",
"standard ", etc., while preserving valid inputs.
Impact:
- Minimal change, isolated to one function.
- No breaking changes for valid callers.
- Fixes test VND-UPD-020 and ensures data integrity.
Signed-off-by: JEAN REGIS <240509606@firat.edu.tr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #235 by adding validation to
trust_levelinupdate_vendor_status, ensuring only"low","standard", or"high"are accepted.Problem
The function currently accepts any string, including values with leading/trailing spaces (e.g.,
" standard"). These invalid values are stored in the database, causing later comparisons liketrust_level == "standard"to fail silently. TestVND-UPD-020demonstrates this issue.Root Cause
No input validation is performed on the
trust_levelparameter. The value is passed directly to the repository and persisted, bypassing any intended restrictions.Solution
I added a validation block before the repository call:
VALID_TRUST_LEVELS = {"low", "standard", "high"}ValueErroriftrust_levelis not in this setThis change is minimal and isolated to one function.
Impact
"low","standard","high") remain unchanged.Testing
test_vnd_upd_020_leading_space_trust_level_accepted_without_validationnow passes.Related Issue
Closes #235