Fix to complete CI issue: /fix/session timezone and rotation test#262
Open
steadhac wants to merge 3 commits intoGenAI-Security-Project:mainfrom
Open
Fix to complete CI issue: /fix/session timezone and rotation test#262steadhac wants to merge 3 commits intoGenAI-Security-Project:mainfrom
steadhac wants to merge 3 commits intoGenAI-Security-Project:mainfrom
Conversation
…ity-Project#27) New test files covering definition loading, registry, primitives, and all six detector implementations. Includes bug-exposing tests for 13 confirmed production defects (GenAI-Security-Project#117, GenAI-Security-Project#119, GenAI-Security-Project#122–GenAI-Security-Project#127, GenAI-Security-Project#128–GenAI-Security-Project#131, GenAI-Security-Project#135). Tests follow established pattern: Title, Basically question, Steps, Expected Results, Impact. Parent: Unit tests creation for CD001 GenAI-Security-Project#27
… 57 tests for 6 detector implementations with 5 bug-documenting tests (DET-RCE-011, DET-INF-009, DET-TPX-011, DET-TPD-010, DET-IEX-009) - 27 evaluator tests including 2 bugs (EVAL-IA-006, EVAL-VC-007) - Route test_evaluators.py
- Apply timezone-naive guard to get_security_status() — same pattern already used in should_rotate() and is_too_old() but was missed here - Update test_session_rotation_preserves_hmac to match current rotation behavior: old session is kept alive briefly (≤60s) for concurrent requests, not deleted immediately
Collaborator
|
this PR #210 does the same and resolved the issue. Please revisit the change and make adjustments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: resolve timezone and stale-assertion gaps missed by 39073eb
already used in should_rotate() and is_too_old() but was missed here
behavior: old session is kept alive briefly (≤60s) for concurrent
requests, not deleted immediately