fix(vendor): prevent None agent_notes writing literal string to DB#267
Open
sshekhar-04 wants to merge 3 commits intoGenAI-Security-Project:mainfrom
Open
fix(vendor): prevent None agent_notes writing literal string to DB#267sshekhar-04 wants to merge 3 commits intoGenAI-Security-Project:mainfrom
sshekhar-04 wants to merge 3 commits intoGenAI-Security-Project:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #143
When
update_vendor_statusandupdate_vendor_agent_notesarecalled with
agent_notes=None, f-string interpolation writes theliteral string "\n\nNone" into the vendor audit trail.
Fix
Added
or ''guard with.strip()on agent_notes in both functions.Before:
After:
Files Changed
finbot/tools/data/vendor.py— fixed 2 occurrencestests/unit/tools/test_vendor.py— added 6 testsTests ✅
All 6 passing.
Closes #143