fix: raise TypeError for non-dict config in BaseDetector#276
Open
deveshreddyp wants to merge 1 commit intoGenAI-Security-Project:mainfrom
Open
fix: raise TypeError for non-dict config in BaseDetector#276deveshreddyp wants to merge 1 commit intoGenAI-Security-Project:mainfrom
deveshreddyp wants to merge 1 commit intoGenAI-Security-Project:mainfrom
Conversation
Contributor
|
@saikishu @steadhac Hey, just a heads up - PR #261 already fixes #117 along with #131 and #130. This PR might be a duplicate. Worth checking #261 before merging this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #117
Added type validation in the
BaseDetectorconstructor to explicitly raise aTypeErrorwhen a non-dictionary config is passed. This prevents downstreamAttributeErrorcrashes and ensures cleaner error handling in the detection pipeline.cc @steadhac - Fixed per the "Must Fix" bugs list!
(Note: The detector-specific
pytestchecks are all passing green locally. There are a few unrelated environment failures onmainlike the Windows path separator intest_sqlite_url, but the core detection suite is clean). Let me know if you need any adjustments!